Skip to content

Turbopack: refactor data storage to avoid reverse task cache #88492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sokra merged 6 commits into from
Jan 23, 2026
Merged

Turbopack: refactor data storage to avoid reverse task cache #88492

sokra merged 6 commits into from
Jan 23, 2026

Conversation

@sokra
Copy link
Member

@sokra sokra commented Jan 13, 2026 •
edited
Loading

What?

  • task type is stored as CachedDataItem
  • reverse task cache is removed

This was referenced Jan 13, 2026
Merged
Merged
@nextjs-bot nextjs-bot added created-by: Turbopack team PRs by the Turbopack team. Turbopack Related to Turbopack with Next.js. labels Jan 13, 2026
This was referenced Jan 13, 2026
Merged
Merged
Merged
Merged
Draft
Merged
Merged
@sokra Graphite App
Copy link
Member Author

sokra commented Jan 13, 2026 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@sokra sokra mentioned this pull request Jan 13, 2026
Merged
@nextjs-bot
Copy link
Collaborator

nextjs-bot commented Jan 13, 2026

Allow CI Workflow Run

  • approve CI run for commit: 53af8c2

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

vercel[bot]
vercel bot reviewed Jan 13, 2026
View reviewed changes
@nextjs-bot
Copy link
Collaborator

nextjs-bot commented Jan 13, 2026 •
edited
Loading

Tests Passed

@nextjs-bot
Copy link
Collaborator

nextjs-bot commented Jan 13, 2026 •
edited
Loading

Stats from current PR

✅ No significant changes detected

📊 All Metrics
📖 Metrics Glossary

Dev Server Metrics:

  • Listen = TCP port starts accepting connections
  • First Request = HTTP server returns successful response
  • Cold = Fresh build (no cache)
  • Warm = With cached build artifacts

Build Metrics:

  • Fresh = Clean build (no .next directory)
  • Cached = With existing .next directory

Change Thresholds:

  • Time: Changes < 50ms AND < 10%, OR < 2% are insignificant
  • Size: Changes < 1KB AND < 1% are insignificant
  • All other changes are flagged to catch regressions

⚡ Dev Server

Metric Canary PR Change Trend
Cold (Listen) 508ms 558ms ✓ ▁▁▁█▁
Cold (Ready in log) 497ms 514ms ✓ ▇▇▆▄▇
Cold (First Request) 998ms 971ms ✓ ███▁█
Warm (Listen) 508ms 507ms ✓ ▁▁▁▁▁
Warm (Ready in log) 469ms 467ms ✓ ▁▂▁▅▁
Warm (First Request) 353ms 350ms ✓ ▇▆▁▅█
📦 Dev Server (Webpack) (Legacy)

📦 Dev Server (Webpack)

Metric Canary PR Change Trend
Cold (Listen) 455ms 456ms ✓ ▅▅▅▅▁
Cold (Ready in log) 438ms 437ms ✓ ▆▇▇▆█
Cold (First Request) 1.833s 1.841s ✓ ▅▆▅▅█
Warm (Listen) 456ms 456ms ✓ ▅███▅
Warm (Ready in log) 438ms 437ms ✓ ▄▄▅▅█
Warm (First Request) 1.853s 1.838s ✓ ▄▅▄▅█

⚡ Production Builds

Metric Canary PR Change Trend
Fresh Build 4.847s 4.848s ✓ ▃▁▁▆▁
Cached Build 4.839s 5.042s ✓ ▁▁▁▆▁
📦 Production Builds (Webpack) (Legacy)

📦 Production Builds (Webpack)

Metric Canary PR Change Trend
Fresh Build 14.124s 14.052s ✓ ▃▄▃▃▇
Cached Build 14.211s 14.202s ✓ ▁▃▃▂▆
node_modules Size 461 MB 461 MB ✓ ▁▁▁▁█
📦 Bundle Sizes

Bundle Sizes

⚡ Turbopack

Client

Main Bundles: **432 kB** → **432 kB** ✅ -32 B

82 files with content-based hashes (individual files not comparable between builds)

Server

Middleware
Canary PR Change
middleware-b..fest.js gzip 762 B 768 B ✓
Total 762 B 768 B ⚠️ +6 B
Build Details
Build Manifests
Canary PR Change
_buildManifest.js gzip 450 B 451 B ✓
Total 450 B 451 B ⚠️ +1 B

📦 Webpack

Client

Main Bundles
Canary PR Change
2086.HASH.js gzip 169 B N/A -
2161-HASH.js gzip 5.41 kB N/A -
2747-HASH.js gzip 4.48 kB N/A -
4322-HASH.js gzip 52.7 kB N/A -
ec793fe8-HASH.js gzip 62.3 kB N/A -
framework-HASH.js gzip 59.8 kB 59.8 kB ✓
main-app-HASH.js gzip 251 B 254 B 🔴 +3 B (+1%)
main-HASH.js gzip 38.7 kB 39.1 kB ✓
webpack-HASH.js gzip 1.68 kB 1.68 kB ✓
1596.HASH.js gzip N/A 169 B -
2658-HASH.js gzip N/A 52.4 kB -
6349-HASH.js gzip N/A 4.46 kB -
7019-HASH.js gzip N/A 5.43 kB -
b17a3386-HASH.js gzip N/A 62.3 kB -
Total 226 kB 226 kB ⚠️ +55 B
Polyfills
Canary PR Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB ✓
Total 39.4 kB 39.4 kB ✓
Pages
Canary PR Change
_app-HASH.js gzip 194 B 193 B ✓
_error-HASH.js gzip 182 B 182 B ✓
css-HASH.js gzip 336 B 335 B ✓
dynamic-HASH.js gzip 1.8 kB 1.8 kB ✓
edge-ssr-HASH.js gzip 256 B 256 B ✓
head-HASH.js gzip 352 B 349 B ✓
hooks-HASH.js gzip 385 B 384 B ✓
image-HASH.js gzip 580 B 580 B ✓
index-HASH.js gzip 259 B 258 B ✓
link-HASH.js gzip 2.5 kB 2.51 kB ✓
routerDirect..HASH.js gzip 319 B 317 B ✓
script-HASH.js gzip 385 B 387 B ✓
withRouter-HASH.js gzip 316 B 315 B ✓
1afbb74e6ecf..834.css gzip 106 B 106 B ✓
Total 7.97 kB 7.96 kB ✅ -8 B

Server

Edge SSR
Canary PR Change
edge-ssr.js gzip 126 kB 126 kB ✓
page.js gzip 244 kB 240 kB 🟢 4.52 kB (-2%)
Total 371 kB 366 kB ✅ -4.64 kB
Middleware
Canary PR Change
middleware-b..fest.js gzip 617 B 617 B ✓
middleware-r..fest.js gzip 155 B 156 B ✓
middleware.js gzip 33 kB 33.3 kB ✓
edge-runtime..pack.js gzip 842 B 842 B ✓
Total 34.7 kB 34.9 kB ⚠️ +243 B
Build Details
Build Manifests
Canary PR Change
_buildManifest.js gzip 738 B 738 B ✓
Total 738 B 738 B ✓
Build Cache
Canary PR Change
0.pack gzip 3.71 MB 3.72 MB 🔴 +8.05 kB (+0%)
index.pack gzip 103 kB 101 kB 🟢 1.41 kB (-1%)
index.pack.old gzip 101 kB 102 kB ✓
Total 3.91 MB 3.92 MB ⚠️ +7.65 kB

🔄 Shared (bundler-independent)

Runtimes
Canary PR Change
app-page-exp...dev.js gzip 306 kB 306 kB ✓
app-page-exp..prod.js gzip 163 kB 163 kB ✓
app-page-tur...dev.js gzip 306 kB 306 kB ✓
app-page-tur..prod.js gzip 163 kB 163 kB ✓
app-page-tur...dev.js gzip 303 kB 303 kB ✓
app-page-tur..prod.js gzip 161 kB 161 kB ✓
app-page.run...dev.js gzip 303 kB 303 kB ✓
app-page.run..prod.js gzip 161 kB 161 kB ✓
app-route-ex...dev.js gzip 69.4 kB 69.4 kB ✓
app-route-ex..prod.js gzip 48.2 kB 48.2 kB ✓
app-route-tu...dev.js gzip 69.5 kB 69.5 kB ✓
app-route-tu..prod.js gzip 48.2 kB 48.2 kB ✓
app-route-tu...dev.js gzip 69.1 kB 69.1 kB ✓
app-route-tu..prod.js gzip 48 kB 48 kB ✓
app-route.ru...dev.js gzip 69 kB 69 kB ✓
app-route.ru..prod.js gzip 48 kB 48 kB ✓
dist_client_...dev.js gzip 324 B 324 B ✓
dist_client_...dev.js gzip 326 B 326 B ✓
dist_client_...dev.js gzip 318 B 318 B ✓
dist_client_...dev.js gzip 317 B 317 B ✓
pages-api-tu...dev.js gzip 42.5 kB 42.5 kB ✓
pages-api-tu..prod.js gzip 32.3 kB 32.3 kB ✓
pages-api.ru...dev.js gzip 42.5 kB 42.5 kB ✓
pages-api.ru..prod.js gzip 32.3 kB 32.3 kB ✓
pages-turbo....dev.js gzip 51.8 kB 51.8 kB ✓
pages-turbo...prod.js gzip 38.8 kB 38.8 kB ✓
pages.runtim...dev.js gzip 51.8 kB 51.8 kB ✓
pages.runtim..prod.js gzip 38.8 kB 38.8 kB ✓
server.runti..prod.js gzip 62.3 kB 62.3 kB ✓
Total 2.73 MB 2.73 MB ⚠️ +2 B

@sokra sokra force-pushed the sokra/chunk-item-id-selective branch from df2c985 to 1bb9198 Compare January 13, 2026 16:40
@sokra sokra force-pushed the sokra/remove-reverse-task-cache branch from 53af8c2 to 1b75cbb Compare January 13, 2026 16:40
@codspeed-hq
Copy link

codspeed-hq bot commented Jan 13, 2026 •
edited
Loading

CodSpeed Performance Report

Merging this PR will not alter performance

Comparing sokra/remove-reverse-task-cache (1949413) with canary (4fe058f)

Summary

✅ 17 untouched benchmarks
⏩ 3 skipped benchmarks1

Footnotes

  1. 3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@sokra sokra force-pushed the sokra/chunk-item-id-selective branch from 1bb9198 to 4aedf59 Compare January 13, 2026 20:26
@sokra sokra force-pushed the sokra/remove-reverse-task-cache branch from 1b75cbb to 20aaa2a Compare January 13, 2026 20:27
@sokra sokra marked this pull request as ready for review January 13, 2026 23:39
@sokra sokra requested a review from mischnic January 13, 2026 23:39
@sokra sokra force-pushed the sokra/remove-reverse-task-cache branch from 20aaa2a to 5b650b7 Compare January 14, 2026 20:08
@sokra sokra force-pushed the sokra/chunk-item-id-selective branch from 4aedf59 to 0fbd239 Compare January 14, 2026 20:08
This was referenced Jan 14, 2026
Merged
Merged
Merged
Merged
@graphite-app graphite-app bot changed the base branch from graphite-base/88492 to canary January 16, 2026 15:46
@sokra sokra force-pushed the sokra/remove-reverse-task-cache branch from e576a06 to d579cd6 Compare January 16, 2026 15:46
@bgw bgw requested a review from lukesandberg January 17, 2026 01:05
lukesandberg
lukesandberg reviewed Jan 17, 2026
View reviewed changes
@sokra sokra requested a review from lukesandberg January 19, 2026 17:54
@sokra sokra force-pushed the sokra/remove-reverse-task-cache branch from d579cd6 to 4ddf51a Compare January 19, 2026 17:55
This was referenced Jan 19, 2026
Draft
Open
Merged
@lukesandberg lukesandberg force-pushed the sokra/remove-reverse-task-cache branch from 4ddf51a to 8d6e009 Compare January 22, 2026 07:06
@sokra sokra force-pushed the sokra/remove-reverse-task-cache branch from 364c305 to 453ddfa Compare January 22, 2026 08:23
@lukesandberg lukesandberg force-pushed the sokra/remove-reverse-task-cache branch from 453ddfa to 0c1d348 Compare January 22, 2026 17:30
This was referenced Jan 22, 2026
Merged
Draft
lukesandberg
lukesandberg reviewed Jan 22, 2026
View reviewed changes
turbopack/crates/turbo-tasks-backend/src/backend/mod.rs
.flatten()
} {
// Task exists in backing storage
// So we only need to insert it into the in-memory cahce
Copy link
Contributor

@lukesandberg lukesandberg Jan 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// So we only need to insert it into the in-memory cahce
// So we only need to insert it into the in-memory cache

@sokra sokra force-pushed the sokra/remove-reverse-task-cache branch from 0c1d348 to c043d4f Compare January 22, 2026 20:50
@sokra sokra force-pushed the sokra/remove-reverse-task-cache branch from c043d4f to 1949413 Compare January 23, 2026 06:58
@sokra sokra merged commit 9e97759 into canary Jan 23, 2026
162 of 164 checks passed
@sokra sokra deleted the sokra/remove-reverse-task-cache branch January 23, 2026 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lukesandberg lukesandberg lukesandberg approved these changes

@vercel vercel[bot] vercel[bot] left review comments

@mischnic mischnic Awaiting requested review from mischnic

@bgw bgw Awaiting requested review from bgw

+1 more reviewer

@naveenkarmegam naveenkarmegam naveenkarmegam approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

created-by: Turbopack team PRs by the Turbopack team. Turbopack Related to Turbopack with Next.js.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@sokra @nextjs-bot @lukesandberg @naveenkarmegam