Skip to content

Conversation

@sokra
Copy link
Member

@sokra sokra commented Jan 19, 2026

What?

Allow keys for selective reads to be something equivalent to the key instead of only exactly a reference of the key.

Copy link
Member Author

sokra commented Jan 19, 2026

@sokra sokra marked this pull request as ready for review January 19, 2026 18:02
@nextjs-bot
Copy link
Collaborator

nextjs-bot commented Jan 19, 2026

Stats from current PR

✅ No significant changes detected

📊 All Metrics
📖 Metrics Glossary

Dev Server Metrics:

  • Listen = TCP port starts accepting connections
  • First Request = HTTP server returns successful response
  • Cold = Fresh build (no cache)
  • Warm = With cached build artifacts

Build Metrics:

  • Fresh = Clean build (no .next directory)
  • Cached = With existing .next directory

Change Thresholds:

  • Time: Changes < 50ms AND < 10%, OR < 2% are insignificant
  • Size: Changes < 1KB AND < 1% are insignificant
  • All other changes are flagged to catch regressions

⚡ Dev Server

Metric Canary PR Change Trend
Cold (Listen) 558ms 559ms ▅▁▁▁█
Cold (Ready in log) 521ms 537ms ▄▅▆▁█
Cold (First Request) 1.029s 1.048s ▁██▁▅
Warm (Listen) 559ms 508ms ▁▁▁▁█
Warm (Ready in log) 533ms 509ms ▂▁▁▁█
Warm (First Request) 422ms 388ms ▃▆▅▁█

⚡ Production Builds

Metric Canary PR Change Trend
Fresh Build 5.071s 5.319s ▃▁▁▂█
Cached Build 5.245s 5.137s ▄▁▁▂█
📦 Production Builds (Webpack) (Legacy)

📦 Production Builds (Webpack)

Metric Canary PR Change Trend
node_modules Size 461 MB 461 MB ▁████
📦 Bundle Sizes

Bundle Sizes

⚡ Turbopack

Client

Main Bundles: **432 kB** → **432 kB** ✅ -32 B

82 files with content-based hashes (individual files not comparable between builds)

Server

Middleware
Canary PR Change
middleware-b..fest.js gzip 762 B 768 B
Total 762 B 768 B ⚠️ +6 B
Build Details
Build Manifests
Canary PR Change
_buildManifest.js gzip 450 B 451 B
Total 450 B 451 B ⚠️ +1 B

🔄 Shared (bundler-independent)

Runtimes
Canary PR Change
app-page-exp...dev.js gzip 306 kB 306 kB
app-page-exp..prod.js gzip 163 kB 163 kB
app-page-tur...dev.js gzip 306 kB 306 kB
app-page-tur..prod.js gzip 163 kB 163 kB
app-page-tur...dev.js gzip 303 kB 303 kB
app-page-tur..prod.js gzip 161 kB 161 kB
app-page.run...dev.js gzip 303 kB 303 kB
app-page.run..prod.js gzip 161 kB 161 kB
app-route-ex...dev.js gzip 69.4 kB 69.4 kB
app-route-ex..prod.js gzip 48.2 kB 48.2 kB
app-route-tu...dev.js gzip 69.5 kB 69.5 kB
app-route-tu..prod.js gzip 48.2 kB 48.2 kB
app-route-tu...dev.js gzip 69.1 kB 69.1 kB
app-route-tu..prod.js gzip 48 kB 48 kB
app-route.ru...dev.js gzip 69 kB 69 kB
app-route.ru..prod.js gzip 48 kB 48 kB
dist_client_...dev.js gzip 324 B 324 B
dist_client_...dev.js gzip 326 B 326 B
dist_client_...dev.js gzip 318 B 318 B
dist_client_...dev.js gzip 317 B 317 B
pages-api-tu...dev.js gzip 42.5 kB 42.5 kB
pages-api-tu..prod.js gzip 32.3 kB 32.3 kB
pages-api.ru...dev.js gzip 42.5 kB 42.5 kB
pages-api.ru..prod.js gzip 32.3 kB 32.3 kB
pages-turbo....dev.js gzip 51.8 kB 51.8 kB
pages-turbo...prod.js gzip 38.8 kB 38.8 kB
pages.runtim...dev.js gzip 51.8 kB 51.8 kB
pages.runtim..prod.js gzip 38.8 kB 38.8 kB
server.runti..prod.js gzip 62.3 kB 62.3 kB
Total 2.73 MB 2.73 MB ✅ -2 B

@codspeed-hq
Copy link

codspeed-hq bot commented Jan 19, 2026

CodSpeed Performance Report

Merging this PR will not alter performance

Comparing sokra/equivalent-selective-read (84bcebc) with canary (13c47b3)

Summary

✅ 17 untouched benchmarks
⏩ 3 skipped benchmarks1

Footnotes

  1. 3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@sokra sokra force-pushed the sokra/equivalent-selective-read branch from 2494303 to 6282cc0 Compare January 22, 2026 20:50
@sokra sokra force-pushed the sokra/operation-vc-for-global-info branch from fcadcef to 2aafb1a Compare January 22, 2026 20:50
@sokra sokra force-pushed the sokra/equivalent-selective-read branch from 6282cc0 to c634085 Compare January 23, 2026 06:58
@sokra sokra force-pushed the sokra/operation-vc-for-global-info branch 2 times, most recently from 6b2ad20 to e30edb0 Compare January 23, 2026 08:03
@sokra sokra force-pushed the sokra/equivalent-selective-read branch from c634085 to aa12d3e Compare January 23, 2026 08:03
@sokra sokra force-pushed the sokra/operation-vc-for-global-info branch 2 times, most recently from 954b41e to 90a785e Compare January 23, 2026 08:36
@sokra sokra force-pushed the sokra/equivalent-selective-read branch from aa12d3e to 461c2bb Compare January 23, 2026 08:36
@sokra sokra requested a review from mischnic January 23, 2026 09:33
@sokra sokra changed the base branch from sokra/operation-vc-for-global-info to graphite-base/88760 January 23, 2026 09:34
@sokra sokra force-pushed the graphite-base/88760 branch from 90a785e to 13c47b3 Compare January 23, 2026 09:34
@sokra sokra force-pushed the sokra/equivalent-selective-read branch from 461c2bb to 84bcebc Compare January 23, 2026 09:34
@sokra sokra changed the base branch from graphite-base/88760 to canary January 23, 2026 09:34
@sokra sokra merged commit 088bbd8 into canary Jan 23, 2026
130 of 142 checks passed
Copy link
Member Author

sokra commented Jan 23, 2026

Merge activity

@sokra sokra deleted the sokra/equivalent-selective-read branch January 23, 2026 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

created-by: Turbopack team PRs by the Turbopack team. Turbopack Related to Turbopack with Next.js.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants