Skip to content

Turbopack: change invalidator and immutable to data category #88889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sokra merged 1 commit into from
Jan 23, 2026
Merged

Turbopack: change invalidator and immutable to data category #88889

sokra merged 1 commit into from
Jan 23, 2026
+3 −3

Conversation

@sokra
Copy link
Member

@sokra sokra commented Jan 22, 2026 •
edited
Loading

What?

save a few bits

@sokra sokra marked this pull request as ready for review January 22, 2026 10:05
@codspeed-hq
Copy link

codspeed-hq bot commented Jan 22, 2026 •
edited
Loading

Merging this PR will not alter performance

✅ 17 untouched benchmarks
⏩ 3 skipped benchmarks1

Comparing sokra/data-category (0c170b6) with canary (9e97759)

Open in CodSpeed

Footnotes

  1. 3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@nextjs-bot
Copy link
Collaborator

nextjs-bot commented Jan 22, 2026 •
edited
Loading

Stats from current PR

✅ No significant changes detected

📊 All Metrics
📖 Metrics Glossary

Dev Server Metrics:

  • Listen = TCP port starts accepting connections
  • First Request = HTTP server returns successful response
  • Cold = Fresh build (no cache)
  • Warm = With cached build artifacts

Build Metrics:

  • Fresh = Clean build (no .next directory)
  • Cached = With existing .next directory

Change Thresholds:

  • Time: Changes < 50ms AND < 10%, OR < 2% are insignificant
  • Size: Changes < 1KB AND < 1% are insignificant
  • All other changes are flagged to catch regressions

⚡ Dev Server

Metric Canary PR Change Trend
Cold (Listen) 455ms 456ms ✓ ▁▁█▁▁
Cold (Ready in log) 437ms 438ms ✓ ▇▆▄▇▇
Cold (First Request) 1.142s 1.178s ✓ ██▁██
Warm (Listen) 456ms 457ms ✓ ▁▁▁▁▁
Warm (Ready in log) 442ms 441ms ✓ ▂▁▅▁▁
Warm (First Request) 343ms 339ms ✓ ▆▁▄█▆
📦 Dev Server (Webpack) (Legacy)

📦 Dev Server (Webpack)

Metric Canary PR Change Trend
Cold (Listen) 455ms 455ms ✓ ▅▅▅▁▁
Cold (Ready in log) 438ms 438ms ✓ ▇▇▆▇█
Cold (First Request) 1.847s 1.840s ✓ ▆▅▅█▆
Warm (Listen) 456ms 456ms ✓ ███▁▁
Warm (Ready in log) 439ms 438ms ✓ ▄▅▅█▆
Warm (First Request) 1.843s 1.850s ✓ ▅▄▅█▅

⚡ Production Builds

Metric Canary PR Change Trend
Fresh Build 4.288s 4.411s ✓ ▁▁▆▁▁
Cached Build 4.333s 4.369s ✓ ▁▁▆▁▁
📦 Production Builds (Webpack) (Legacy)

📦 Production Builds (Webpack)

Metric Canary PR Change Trend
Fresh Build 14.125s 14.126s ✓ ▄▃▃▇▃
Cached Build 14.180s 14.281s ✓ ▃▃▂▆▃
node_modules Size 461 MB 461 MB ✓ ▁▁▁██
📦 Bundle Sizes

Bundle Sizes

⚡ Turbopack

Client

Main Bundles: **432 kB** → **432 kB** ✅ -32 B

82 files with content-based hashes (individual files not comparable between builds)

Server

Middleware
Canary PR Change
middleware-b..fest.js gzip 762 B 768 B ✓
Total 762 B 768 B ⚠️ +6 B
Build Details
Build Manifests
Canary PR Change
_buildManifest.js gzip 450 B 451 B ✓
Total 450 B 451 B ⚠️ +1 B

📦 Webpack

Client

Main Bundles
Canary PR Change
2086.HASH.js gzip 169 B N/A -
2161-HASH.js gzip 5.41 kB N/A -
2747-HASH.js gzip 4.48 kB N/A -
4322-HASH.js gzip 52.7 kB N/A -
ec793fe8-HASH.js gzip 62.3 kB N/A -
framework-HASH.js gzip 59.8 kB 59.8 kB ✓
main-app-HASH.js gzip 251 B 254 B 🔴 +3 B (+1%)
main-HASH.js gzip 38.7 kB 39.1 kB ✓
webpack-HASH.js gzip 1.68 kB 1.68 kB ✓
1596.HASH.js gzip N/A 169 B -
2658-HASH.js gzip N/A 52.4 kB -
6349-HASH.js gzip N/A 4.46 kB -
7019-HASH.js gzip N/A 5.43 kB -
b17a3386-HASH.js gzip N/A 62.3 kB -
Total 226 kB 226 kB ⚠️ +55 B
Polyfills
Canary PR Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB ✓
Total 39.4 kB 39.4 kB ✓
Pages
Canary PR Change
_app-HASH.js gzip 194 B 193 B ✓
_error-HASH.js gzip 182 B 182 B ✓
css-HASH.js gzip 336 B 335 B ✓
dynamic-HASH.js gzip 1.8 kB 1.8 kB ✓
edge-ssr-HASH.js gzip 256 B 256 B ✓
head-HASH.js gzip 352 B 349 B ✓
hooks-HASH.js gzip 385 B 384 B ✓
image-HASH.js gzip 580 B 580 B ✓
index-HASH.js gzip 259 B 258 B ✓
link-HASH.js gzip 2.5 kB 2.51 kB ✓
routerDirect..HASH.js gzip 319 B 317 B ✓
script-HASH.js gzip 385 B 387 B ✓
withRouter-HASH.js gzip 316 B 315 B ✓
1afbb74e6ecf..834.css gzip 106 B 106 B ✓
Total 7.97 kB 7.96 kB ✅ -8 B

Server

Edge SSR
Canary PR Change
edge-ssr.js gzip 126 kB 126 kB ✓
page.js gzip 244 kB 240 kB 🟢 4.5 kB (-2%)
Total 371 kB 366 kB ✅ -4.62 kB
Middleware
Canary PR Change
middleware-b..fest.js gzip 618 B 617 B ✓
middleware-r..fest.js gzip 155 B 156 B ✓
middleware.js gzip 33.1 kB 33.2 kB ✓
edge-runtime..pack.js gzip 842 B 842 B ✓
Total 34.7 kB 34.8 kB ⚠️ +85 B
Build Details
Build Manifests
Canary PR Change
_buildManifest.js gzip 738 B 738 B ✓
Total 738 B 738 B ✓
Build Cache
Canary PR Change
0.pack gzip 3.71 MB 3.72 MB 🔴 +9.48 kB (+0%)
index.pack gzip 101 kB 102 kB ✓
index.pack.old gzip 102 kB 101 kB 🟢 1.31 kB (-1%)
Total 3.91 MB 3.92 MB ⚠️ +8.55 kB

🔄 Shared (bundler-independent)

Runtimes
Canary PR Change
app-page-exp...dev.js gzip 306 kB 306 kB ✓
app-page-exp..prod.js gzip 163 kB 163 kB ✓
app-page-tur...dev.js gzip 306 kB 306 kB ✓
app-page-tur..prod.js gzip 163 kB 163 kB ✓
app-page-tur...dev.js gzip 303 kB 303 kB ✓
app-page-tur..prod.js gzip 161 kB 161 kB ✓
app-page.run...dev.js gzip 303 kB 303 kB ✓
app-page.run..prod.js gzip 161 kB 161 kB ✓
app-route-ex...dev.js gzip 69.4 kB 69.4 kB ✓
app-route-ex..prod.js gzip 48.2 kB 48.2 kB ✓
app-route-tu...dev.js gzip 69.5 kB 69.5 kB ✓
app-route-tu..prod.js gzip 48.2 kB 48.2 kB ✓
app-route-tu...dev.js gzip 69.1 kB 69.1 kB ✓
app-route-tu..prod.js gzip 48 kB 48 kB ✓
app-route.ru...dev.js gzip 69 kB 69 kB ✓
app-route.ru..prod.js gzip 48 kB 48 kB ✓
dist_client_...dev.js gzip 324 B 324 B ✓
dist_client_...dev.js gzip 326 B 326 B ✓
dist_client_...dev.js gzip 318 B 318 B ✓
dist_client_...dev.js gzip 317 B 317 B ✓
pages-api-tu...dev.js gzip 42.5 kB 42.5 kB ✓
pages-api-tu..prod.js gzip 32.3 kB 32.3 kB ✓
pages-api.ru...dev.js gzip 42.5 kB 42.5 kB ✓
pages-api.ru..prod.js gzip 32.3 kB 32.3 kB ✓
pages-turbo....dev.js gzip 51.8 kB 51.8 kB ✓
pages-turbo...prod.js gzip 38.8 kB 38.8 kB ✓
pages.runtim...dev.js gzip 51.8 kB 51.8 kB ✓
pages.runtim..prod.js gzip 38.8 kB 38.8 kB ✓
server.runti..prod.js gzip 62.3 kB 62.3 kB ✓
Total 2.73 MB 2.73 MB ⚠️ +5 B

@sokra sokra mentioned this pull request Jan 22, 2026
Merged
lukesandberg
lukesandberg approved these changes Jan 22, 2026
View reviewed changes
Copy link
Contributor

@lukesandberg lukesandberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lukesandberg approved this PR from Slack with Graphite

@lukesandberg lukesandberg changed the base branch from sokra/remove-reverse-task-cache to graphite-base/88889 January 22, 2026 17:30
This was referenced Jan 22, 2026
Merged
Merged
Merged
Merged
Draft
Open
@lukesandberg Graphite App
Copy link
Contributor

lukesandberg commented Jan 22, 2026 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

This was referenced Jan 22, 2026
Merged
Draft
@sokra sokra force-pushed the graphite-base/88889 branch from 453ddfa to c043d4f Compare January 22, 2026 20:50
@sokra sokra force-pushed the sokra/data-category branch from 7f499d1 to 282273c Compare January 22, 2026 20:50
@nextjs-bot nextjs-bot added created-by: Turbopack team PRs by the Turbopack team. Turbopack Related to Turbopack with Next.js. labels Jan 22, 2026
@sokra sokra changed the base branch from graphite-base/88889 to sokra/remove-reverse-task-cache January 22, 2026 20:51
@nextjs-bot
Copy link
Collaborator

nextjs-bot commented Jan 22, 2026 •
edited
Loading

Tests Passed

@sokra sokra force-pushed the sokra/data-category branch from 282273c to 85a9eea Compare January 23, 2026 06:58
@sokra sokra force-pushed the sokra/remove-reverse-task-cache branch from c043d4f to 1949413 Compare January 23, 2026 06:58
@sokra sokra changed the base branch from sokra/remove-reverse-task-cache to graphite-base/88889 January 23, 2026 08:02
@sokra sokra force-pushed the sokra/data-category branch from 85a9eea to f7f5480 Compare January 23, 2026 08:02
@sokra sokra force-pushed the graphite-base/88889 branch from 1949413 to 9e97759 Compare January 23, 2026 08:02
@graphite-app graphite-app bot changed the base branch from graphite-base/88889 to canary January 23, 2026 08:03
@sokra sokra force-pushed the sokra/data-category branch from f7f5480 to 0c170b6 Compare January 23, 2026 08:03
@sokra sokra merged commit cedfb53 into canary Jan 23, 2026
164 checks passed
@sokra Graphite App
Copy link
Member Author

sokra commented Jan 23, 2026

Merge activity

@sokra sokra deleted the sokra/data-category branch January 23, 2026 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lukesandberg lukesandberg lukesandberg approved these changes

@bgw bgw Awaiting requested review from bgw

@mischnic mischnic Awaiting requested review from mischnic

Assignees

No one assigned

Labels

created-by: Turbopack team PRs by the Turbopack team. Turbopack Related to Turbopack with Next.js.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sokra @nextjs-bot @lukesandberg