Skip to content

Conversation

@sokra
Copy link
Member

@sokra sokra commented Jan 12, 2026

What?

Use selection reads for module id to avoid functions

@nextjs-bot
Copy link
Collaborator

Allow CI Workflow Run

  • approve CI run for commit: 38833eb

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

@nextjs-bot
Copy link
Collaborator

nextjs-bot commented Jan 12, 2026

Stats from current PR

✅ No significant changes detected

📊 All Metrics
📖 Metrics Glossary

Dev Server Metrics:

  • Listen = TCP port starts accepting connections
  • First Request = HTTP server returns successful response
  • Cold = Fresh build (no cache)
  • Warm = With cached build artifacts

Build Metrics:

  • Fresh = Clean build (no .next directory)
  • Cached = With existing .next directory

Change Thresholds:

  • Time: Changes < 50ms AND < 10%, OR < 2% are insignificant
  • Size: Changes < 1KB AND < 1% are insignificant
  • All other changes are flagged to catch regressions

⚡ Dev Server

Metric Canary PR Change Trend
Cold (Listen) 505ms 507ms ▁▁▁█▁
Cold (Ready in log) 462ms 460ms ▁▅▇▅▆
Cold (First Request) 901ms 909ms ▁▇█▃█
Warm (Listen) 505ms 505ms ▁▁▁▅▁
Warm (Ready in log) 460ms 459ms ▁▁▁▅▁
Warm (First Request) 334ms 354ms ▁▁▁▆▅
📦 Dev Server (Webpack) (Legacy)

📦 Dev Server (Webpack)

Metric Canary PR Change Trend
Cold (Listen) 456ms 456ms ▁▁▁▁▁
Cold (Ready in log) 440ms 440ms ▅▇▁▁▇
Cold (First Request) 1.822s 1.809s ▃▄▁▁▅
Warm (Listen) 456ms 456ms ▁▁▁▁▁
Warm (Ready in log) 439ms 441ms ▅▅▁▁▅
Warm (First Request) 1.817s 1.826s ▄▄▁▁▅

⚡ Production Builds

Metric Canary PR Change Trend
Fresh Build 4.752s 4.777s ▂▁▁▇▁
Cached Build 4.758s 4.767s ▂▁▂▇▁
📦 Production Builds (Webpack) (Legacy)

📦 Production Builds (Webpack)

Metric Canary PR Change Trend
Fresh Build 13.933s 13.908s ▁▁▁▁▃
Cached Build 14.034s 14.031s ▁▁▂▁▃
node_modules Size 458 MB 458 MB ▁▁▁▁▁
📦 Bundle Sizes

Bundle Sizes

⚡ Turbopack

Client

Main Bundles: **430 kB** → **430 kB** ✅ -81 B

82 files with content-based hashes (individual files not comparable between builds)

Server

Middleware
Canary PR Change
middleware-b..fest.js gzip 790 B 785 B
Total 790 B 785 B ✅ -5 B
Build Details
Build Manifests
Canary PR Change
_buildManifest.js gzip 449 B 450 B
Total 449 B 450 B ⚠️ +1 B

📦 Webpack

Client

Main Bundles
Canary PR Change
2086.HASH.js gzip 169 B N/A -
2161-HASH.js gzip 5.41 kB N/A -
2747-HASH.js gzip 4.48 kB N/A -
4322-HASH.js gzip 52.3 kB N/A -
ec793fe8-HASH.js gzip 62.3 kB N/A -
framework-HASH.js gzip 59.8 kB 59.8 kB
main-app-HASH.js gzip 251 B 254 B 🔴 +3 B (+1%)
main-HASH.js gzip 38.6 kB 38.9 kB
webpack-HASH.js gzip 1.68 kB 1.68 kB
1596.HASH.js gzip N/A 169 B -
2658-HASH.js gzip N/A 51.9 kB -
6349-HASH.js gzip N/A 4.46 kB -
7019-HASH.js gzip N/A 5.43 kB -
b17a3386-HASH.js gzip N/A 62.3 kB -
Total 225 kB 225 kB ✅ -10 B
Polyfills
Canary PR Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB
Total 39.4 kB 39.4 kB
Pages
Canary PR Change
_app-HASH.js gzip 194 B 193 B
_error-HASH.js gzip 182 B 182 B
css-HASH.js gzip 336 B 335 B
dynamic-HASH.js gzip 1.8 kB 1.8 kB
edge-ssr-HASH.js gzip 256 B 256 B
head-HASH.js gzip 352 B 349 B
hooks-HASH.js gzip 385 B 384 B
image-HASH.js gzip 580 B 580 B
index-HASH.js gzip 259 B 258 B
link-HASH.js gzip 2.5 kB 2.51 kB
routerDirect..HASH.js gzip 319 B 317 B
script-HASH.js gzip 385 B 387 B
withRouter-HASH.js gzip 316 B 315 B
1afbb74e6ecf..834.css gzip 106 B 106 B
Total 7.97 kB 7.96 kB ✅ -8 B

Server

Edge SSR
Canary PR Change
edge-ssr.js gzip 125 kB 125 kB
page.js gzip 242 kB 237 kB 🟢 4.88 kB (-2%)
Total 366 kB 361 kB ✅ -4.86 kB
Middleware
Canary PR Change
middleware-b..fest.js gzip 654 B 653 B
middleware-r..fest.js gzip 155 B 156 B
middleware.js gzip 33 kB 33.3 kB
edge-runtime..pack.js gzip 842 B 842 B
Total 34.7 kB 34.9 kB ⚠️ +281 B
Build Details
Build Manifests
Canary PR Change
_buildManifest.js gzip 738 B 738 B
Total 738 B 738 B
Build Cache
Canary PR Change
0.pack gzip 3.66 MB 3.66 MB 🔴 +4.81 kB (+0%)
index.pack gzip 99.4 kB 99.4 kB
index.pack.old gzip 98.3 kB 99.8 kB 🔴 +1.49 kB (+2%)
Total 3.86 MB 3.86 MB ⚠️ +6.28 kB

🔄 Shared (bundler-independent)

Runtimes
Canary PR Change
app-page-exp...dev.js gzip 303 kB 303 kB
app-page-exp..prod.js gzip 158 kB 158 kB
app-page-tur...dev.js gzip 303 kB 303 kB
app-page-tur..prod.js gzip 158 kB 158 kB
app-page-tur...dev.js gzip 300 kB 300 kB
app-page-tur..prod.js gzip 156 kB 156 kB
app-page.run...dev.js gzip 300 kB 300 kB
app-page.run..prod.js gzip 156 kB 156 kB
app-route-ex...dev.js gzip 68.8 kB 68.8 kB
app-route-ex..prod.js gzip 47.6 kB 47.6 kB
app-route-tu...dev.js gzip 68.8 kB 68.8 kB
app-route-tu..prod.js gzip 47.6 kB 47.6 kB
app-route-tu...dev.js gzip 68.4 kB 68.4 kB
app-route-tu..prod.js gzip 47.4 kB 47.4 kB
app-route.ru...dev.js gzip 68.4 kB 68.4 kB
app-route.ru..prod.js gzip 47.3 kB 47.3 kB
dist_client_...dev.js gzip 324 B 324 B
dist_client_...dev.js gzip 326 B 326 B
dist_client_...dev.js gzip 318 B 318 B
dist_client_...dev.js gzip 317 B 317 B
pages-api-tu...dev.js gzip 41.2 kB 41.2 kB
pages-api-tu..prod.js gzip 31.3 kB 31.3 kB
pages-api.ru...dev.js gzip 41.1 kB 41.1 kB
pages-api.ru..prod.js gzip 31.2 kB 31.2 kB
pages-turbo....dev.js gzip 50.8 kB 50.8 kB
pages-turbo...prod.js gzip 38.2 kB 38.2 kB
pages.runtim...dev.js gzip 50.7 kB 50.7 kB
pages.runtim..prod.js gzip 38.2 kB 38.2 kB
server.runti..prod.js gzip 62.2 kB 62.2 kB
Total 2.69 MB 2.69 MB ✅ -4 B

@sokra sokra force-pushed the sokra/chunk-item-id-selective branch from 38833eb to df2c985 Compare January 13, 2026 15:43
@sokra sokra force-pushed the sokra/aggregation-update-tracing branch from 9dabe82 to ba27300 Compare January 13, 2026 15:43
@codspeed-hq
Copy link

codspeed-hq bot commented Jan 13, 2026

Merging this PR will not alter performance

✅ 17 untouched benchmarks
⏩ 3 skipped benchmarks1


Comparing sokra/chunk-item-id-selective (c2e1c25) with canary (dd39efc)

Open in CodSpeed

Footnotes

  1. 3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@nextjs-bot
Copy link
Collaborator

nextjs-bot commented Jan 13, 2026

Tests Passed

@sokra sokra force-pushed the sokra/aggregation-update-tracing branch from ba27300 to c557e1c Compare January 13, 2026 16:40
@sokra sokra force-pushed the sokra/chunk-item-id-selective branch from df2c985 to 1bb9198 Compare January 13, 2026 16:40
@sokra sokra force-pushed the sokra/aggregation-update-tracing branch from c557e1c to 4173f77 Compare January 13, 2026 20:26
@sokra sokra force-pushed the sokra/chunk-item-id-selective branch from 1bb9198 to 4aedf59 Compare January 13, 2026 20:26
@sokra sokra marked this pull request as ready for review January 13, 2026 23:38
@sokra sokra requested a review from mischnic January 13, 2026 23:38
@sokra sokra force-pushed the sokra/aggregation-update-tracing branch from 229bf89 to d3d174b Compare January 15, 2026 18:37
@sokra sokra force-pushed the sokra/chunk-item-id-selective branch from 93ba0cc to a520ee5 Compare January 15, 2026 18:37
@sokra sokra force-pushed the sokra/aggregation-update-tracing branch from d3d174b to 2c0d6b2 Compare January 15, 2026 19:20
@sokra sokra force-pushed the sokra/chunk-item-id-selective branch from a520ee5 to d0eed51 Compare January 15, 2026 19:21
@sokra sokra force-pushed the sokra/aggregation-update-tracing branch 2 times, most recently from 6f2d839 to 8d53511 Compare January 16, 2026 05:45
@sokra sokra force-pushed the sokra/chunk-item-id-selective branch 2 times, most recently from 6fd4d59 to 81b41b9 Compare January 16, 2026 05:46
@sokra sokra changed the base branch from sokra/aggregation-update-tracing to graphite-base/88411 January 16, 2026 07:04
@sokra sokra force-pushed the graphite-base/88411 branch from 8d53511 to b21b3f6 Compare January 16, 2026 08:12
@sokra sokra force-pushed the sokra/chunk-item-id-selective branch from 81b41b9 to 2c5cc09 Compare January 16, 2026 08:12
@sokra sokra changed the base branch from graphite-base/88411 to sokra/aggregation-update-tracing January 16, 2026 08:12
@sokra sokra requested a review from mischnic January 16, 2026 08:13
@sokra sokra force-pushed the sokra/aggregation-update-tracing branch from b21b3f6 to 89ca808 Compare January 16, 2026 09:00
@sokra sokra force-pushed the sokra/chunk-item-id-selective branch from 2c5cc09 to bab4807 Compare January 16, 2026 09:00
@sokra sokra force-pushed the sokra/aggregation-update-tracing branch 2 times, most recently from bdd5e74 to 4dae3ca Compare January 16, 2026 09:42
@sokra sokra force-pushed the sokra/chunk-item-id-selective branch from bab4807 to bc8fa95 Compare January 16, 2026 09:42
@sokra sokra changed the base branch from sokra/aggregation-update-tracing to graphite-base/88411 January 16, 2026 10:09
@sokra sokra force-pushed the sokra/chunk-item-id-selective branch from bc8fa95 to c2e1c25 Compare January 16, 2026 10:10
@sokra sokra force-pushed the graphite-base/88411 branch from 4dae3ca to dd39efc Compare January 16, 2026 10:10
@graphite-app graphite-app bot changed the base branch from graphite-base/88411 to canary January 16, 2026 10:10
@graphite-app
Copy link
Contributor

graphite-app bot commented Jan 16, 2026

Merge activity

  • Jan 16, 10:10 AM UTC: Graphite rebased this pull request, because this pull request is set to merge when ready.
  • Jan 16, 12:07 PM UTC: @sokra merged this pull request with Graphite.

@sokra sokra merged commit 8d5b937 into canary Jan 16, 2026
384 of 406 checks passed
@sokra sokra deleted the sokra/chunk-item-id-selective branch January 16, 2026 12:07
wyattjoh pushed a commit that referenced this pull request Jan 16, 2026
…tead (#88411)

### What?

Use selection reads for module id to avoid functions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

created-by: Turbopack team PRs by the Turbopack team. Turbopack Related to Turbopack with Next.js.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants