This repository was archived by the owner on Aug 7, 2024. It is now read-only.
[6/x] clean up casting: rename delayed and dynamic casting functions#350
Closed
vkuzo wants to merge 1 commit intogh/vkuzo/59/basefrom
Closed
[6/x] clean up casting: rename delayed and dynamic casting functions#350vkuzo wants to merge 1 commit intogh/vkuzo/59/basefrom
vkuzo wants to merge 1 commit intogh/vkuzo/59/basefrom
Conversation
Summary: Renames the delayed and dynamic casting functions to `hp_tensor_to_float8_delayed` and `hp_tensor_to_float8_dynamic` to clarify what they are doing and how they are different from `hp_tensor_and_scale_to_float8`. Test Plan: ``` ./test/test_everything.sh ``` Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
This was referenced Jul 26, 2024
vkuzo
added a commit
that referenced
this pull request
Jul 26, 2024
Summary: Renames the delayed and dynamic casting functions to `hp_tensor_to_float8_delayed` and `hp_tensor_to_float8_dynamic` to clarify what they are doing and how they are different from `hp_tensor_and_scale_to_float8`. Test Plan: ``` ./test/test_everything.sh ``` Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: 5411766 Pull Request resolved: #350
facebook-github-bot
added
the
CLA Signed
Contributor
Author
|
@vkuzo has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
drisspg
approved these changes
Jul 26, 2024
Contributor
|
This pull request has been merged in 3265474. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Summary:
Renames the delayed and dynamic casting functions to
hp_tensor_to_float8_delayedandhp_tensor_to_float8_dynamicto clarify what they are doing and how they are different from
hp_tensor_and_scale_to_float8.Test Plan:
Reviewers:
Subscribers:
Tasks:
Tags:
Differential Revision: D60310241