This repository was archived by the owner on Aug 7, 2024. It is now read-only.
[4/x] clean up casting: ToFloat8ConstrFunc -> hp_tensor_and_scale_to_float8#348
Closed
vkuzo wants to merge 1 commit intogh/vkuzo/57/basefrom
Closed
[4/x] clean up casting: ToFloat8ConstrFunc -> hp_tensor_and_scale_to_float8#348vkuzo wants to merge 1 commit intogh/vkuzo/57/basefrom
vkuzo wants to merge 1 commit intogh/vkuzo/57/basefrom
Conversation
…float8 Summary: Moves `ToFloat8ConstrFunc` to private, and creates `hp_tensor_and_scale_to_float8` as the official wrapper which clearly describes what this function is doing. A future PR will rename the scaling-aware functions to match this naming. Test Plan: ``` ./test/test_everything.sh ``` Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
facebook-github-bot
added
the
CLA Signed
This was referenced Jul 26, 2024
Contributor
Author
|
@vkuzo has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
drisspg
approved these changes
Jul 26, 2024
Contributor
|
This pull request has been merged in 6ac2f82. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Summary:
Moves
ToFloat8ConstrFuncto private, and createshp_tensor_and_scale_to_float8as the official wrapperwhich clearly describes what this function is doing.
A future PR will rename the scaling-aware functions to match this
naming.
Test Plan:
Reviewers:
Subscribers:
Tasks:
Tags:
Differential Revision: D60310240