This repository was archived by the owner on Aug 7, 2024. It is now read-only.
[5/x] clean up casting: cast_to_float8_e4m3_dynamic -> cast_to_float8_dynamic#349
Closed
vkuzo wants to merge 1 commit intogh/vkuzo/58/basefrom
Closed
[5/x] clean up casting: cast_to_float8_e4m3_dynamic -> cast_to_float8_dynamic#349vkuzo wants to merge 1 commit intogh/vkuzo/58/basefrom
vkuzo wants to merge 1 commit intogh/vkuzo/58/basefrom
Conversation
…_dynamic Summary: Moves the dtype from function name to argument, to match delayed scaling version. Test Plan: ``` ./test/test_everything.sh ``` Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
This was referenced Jul 26, 2024
facebook-github-bot
added
the
CLA Signed
Contributor
Author
|
@vkuzo has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
drisspg
approved these changes
Jul 26, 2024
Contributor
|
This pull request has been merged in 4fb2877. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Summary:
Moves the dtype from function name to argument, to match delayed scaling
version.
Test Plan:
Reviewers:
Subscribers:
Tasks:
Tags:
Differential Revision: D60310239