This repository was archived by the owner on Aug 7, 2024. It is now read-only.
[3/x] clean up casting functions: delete to_fp8_no_autograd#347
Closed
vkuzo wants to merge 2 commits intogh/vkuzo/56/basefrom
Closed
[3/x] clean up casting functions: delete to_fp8_no_autograd#347vkuzo wants to merge 2 commits intogh/vkuzo/56/basefrom
vkuzo wants to merge 2 commits intogh/vkuzo/56/basefrom
Conversation
Summary: `ToFloat8ConstrFunc` was just calling `to_fp8_no_autograd`, unify them to reduce confusion. We can rename the function in a future PR, keeping PRs small for now. Test Plan: ``` ./test/test_everything.sh ``` Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
This was referenced Jul 26, 2024
vkuzo
added a commit
that referenced
this pull request
Jul 26, 2024
Summary: `ToFloat8ConstrFunc` was just calling `to_fp8_no_autograd`, unify them to reduce confusion. We can rename the function in a future PR, keeping PRs small for now. Test Plan: ``` ./test/test_everything.sh ``` Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: f5235ac Pull Request resolved: #347
facebook-github-bot
added
the
CLA Signed
Contributor
Author
|
@vkuzo has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Summary: `ToFloat8ConstrFunc` was just calling `to_fp8_no_autograd`, unify them to reduce confusion. We can rename the function in a future PR, keeping PRs small for now. Test Plan: ``` ./test/test_everything.sh ``` Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D60292694](https://our.internmc.facebook.com/intern/diff/D60292694) [ghstack-poisoned]
This was referenced Jul 26, 2024
Contributor
Author
|
@vkuzo has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
drisspg
approved these changes
Jul 26, 2024
Contributor
|
This pull request has been merged in 7e0182f. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Summary:
ToFloat8ConstrFuncwas just callingto_fp8_no_autograd,unify them to reduce confusion.
We can rename the function in a future PR, keeping PRs small for now.
Test Plan:
Reviewers:
Subscribers:
Tasks:
Tags:
Differential Revision: D60292694