fix: correct precedence parentheses for SQLFragment joins

[wschurman]

Why

There's a bug in where clause construction, which used SQLFragmentHelpers.and: https://github.com/expo/entity/blob/main/packages/entity-database-adapter-knex/src/internal/EntityKnexDataManager.ts#L303

The bug is that given something like:

where: sql`account_id = ${accountId}`,
searchWhere: sql`something ILIKE term OR similarity(term, ...) OR ...`

it would produce

WHERE account_id = ${accountId} AND something ILIKE term OR similarity(term, ...) OR ...

which has the incorrect parentheses and therefore incorrect precedence.

This exposed more bugs in the precedence in or, and, join, etc methods.

How

The fix is multifold:

• Make the public join method only be used for comma-separation joining. Rename it to joinWithCommaSeparator.
• Wrap each group in or and and in parentheses to ensure correct precedence.

  > SQLFragment.or(sql`account_id = ${accountId}`, sql`app_id = ${appId}`
  sql`(account_id = ${accountId}) OR (app_id = ${appId})`
  

Test Plan

Run existing tests to ensure nothing breaks, update unit tests and inspect output SQL statements to ensure they are correct parentheses. Especially the builds complex queries with multiple helpers test case.

[wschurman]

• fix: correct pagination behavior for standard pagination with descending ordering clauses #477
• fix: correct precedence parentheses for SQLFragment joins #476 👈 (View in Graphite)
• feat: add method to get pagination cursor for single entity #475
• fix: correct discriminated union type for forward/backward pagination #474
• feat: support nullable search fields with postgres transforms #470
• fix: Apply same viewer context subclass type mechanism to knexLoader and related methods #472
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (898f71c) to head (ffb7a82).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff            @@
##              main      #476   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          110       110           
  Lines        16183     16198   +15     
  Branches       882       871   -11     
=========================================
+ Hits         16183     16198   +15     

Flag	Coverage Δ
integration	24.17% <90.24%> (+0.08%)	⬆️
unittest	95.00% <70.73%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[wschurman]

Merge activity

• Feb 27, 2:15 AM UTC: A user started a stack merge that includes this pull request via Graphite.
• Feb 27, 2:28 AM UTC: Graphite rebased this pull request as part of a merge.
• Feb 27, 2:31 AM UTC: @wschurman merged this pull request with Graphite.