Skip to content

feat: add method to get pagination cursor for single entity#475

Merged
wschurman merged 1 commit intomainfrom
wschurman/02-26-feat_add_method_to_get_pagination_cursor_for_single_entity
Feb 27, 2026
Merged

feat: add method to get pagination cursor for single entity#475
wschurman merged 1 commit intomainfrom
wschurman/02-26-feat_add_method_to_get_pagination_cursor_for_single_entity

Conversation

@wschurman
Copy link
Member

@wschurman wschurman commented Feb 26, 2026

Why

In a decent number of tests in the Expo server application, it's useful to test pagination from a specific point. It may also be useful for production code in an thus far unbeknownst way.

To do this, one must be able to generate the cursor given an entity. This PR adds such a method.

How

Add the method that creates a cursor.

Test Plan

Run the new test.

@wschurman wschurman force-pushed the wschurman/02-26-fix_correct_discriminated_union_type_for_forward/backward_pagination branch from 8c47c79 to 8fb196e Compare February 26, 2026 21:06
@wschurman wschurman force-pushed the wschurman/02-26-feat_add_method_to_get_pagination_cursor_for_single_entity branch 2 times, most recently from 1206180 to 0ad1b46 Compare February 26, 2026 21:34
@wschurman wschurman force-pushed the wschurman/02-26-fix_correct_discriminated_union_type_for_forward/backward_pagination branch from 8fb196e to f48bc26 Compare February 26, 2026 22:10
@wschurman wschurman force-pushed the wschurman/02-26-feat_add_method_to_get_pagination_cursor_for_single_entity branch from 0ad1b46 to 8d58396 Compare February 26, 2026 22:10
@wschurman wschurman requested review from ide and quinlanj February 26, 2026 22:23
@wschurman wschurman marked this pull request as ready for review February 26, 2026 22:23
@codecov
Copy link

codecov bot commented Feb 27, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (90ae6e2) to head (4b52611).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##              main      #475    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files          110       110            
  Lines        16159     16183    +24     
  Branches       869      1440   +571     
==========================================
+ Hits         16159     16183    +24     
Flag Coverage Δ
integration 24.09% <100.00%> (+0.11%) ⬆️
unittest 95.01% <75.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member Author

wschurman commented Feb 27, 2026

Merge activity

  • Feb 27, 2:15 AM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Feb 27, 2:24 AM UTC: Graphite rebased this pull request as part of a merge.
  • Feb 27, 2:27 AM UTC: @wschurman merged this pull request with Graphite.

@wschurman wschurman changed the base branch from wschurman/02-26-fix_correct_discriminated_union_type_for_forward/backward_pagination to graphite-base/475 February 27, 2026 02:20
@wschurman wschurman changed the base branch from graphite-base/475 to main February 27, 2026 02:23
@wschurman wschurman force-pushed the wschurman/02-26-feat_add_method_to_get_pagination_cursor_for_single_entity branch from 8d58396 to 4b52611 Compare February 27, 2026 02:24
@wschurman wschurman merged commit 898f71c into main Feb 27, 2026
3 checks passed
@wschurman wschurman deleted the wschurman/02-26-feat_add_method_to_get_pagination_cursor_for_single_entity branch February 27, 2026 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants