Skip to content

fix: correct discriminated union type for forward/backward pagination#474

Merged
wschurman merged 1 commit intomainfrom
wschurman/02-26-fix_correct_discriminated_union_type_for_forward/backward_pagination
Feb 27, 2026
Merged

fix: correct discriminated union type for forward/backward pagination#474
wschurman merged 1 commit intomainfrom
wschurman/02-26-fix_correct_discriminated_union_type_for_forward/backward_pagination

Conversation

@wschurman
Copy link
Member

@wschurman wschurman commented Feb 26, 2026

Why

When testing this downstream, I noticed that it was allowed in types to specify first & before / last & after which aren't supported in the pagination.

How

Fix the types by being explicit about the other fields.

Test Plan

yarn tsc

@wschurman wschurman force-pushed the wschurman/02-26-fix_correct_discriminated_union_type_for_forward/backward_pagination branch from 8c47c79 to 8fb196e Compare February 26, 2026 21:06
@wschurman wschurman force-pushed the wschurman/02-25-feat_support_nullable_search_fields_with_postgres_transforms branch from b1772ac to 2aebbfa Compare February 26, 2026 21:06
@wschurman wschurman force-pushed the wschurman/02-26-fix_correct_discriminated_union_type_for_forward/backward_pagination branch from 8fb196e to f48bc26 Compare February 26, 2026 22:10
@wschurman wschurman force-pushed the wschurman/02-25-feat_support_nullable_search_fields_with_postgres_transforms branch from 2aebbfa to 85b1a4c Compare February 26, 2026 22:10
@wschurman wschurman requested review from ide and quinlanj February 26, 2026 22:23
@wschurman wschurman marked this pull request as ready for review February 26, 2026 22:23
Copy link
Member

@ide ide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting. Makes sense.

@codecov
Copy link

codecov bot commented Feb 27, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (53b0604) to head (bf1c639).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #474   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          110       110           
  Lines        16135     16159   +24     
  Branches       869       869           
=========================================
+ Hits         16135     16159   +24     
Flag Coverage Δ
integration 23.98% <100.00%> (+0.11%) ⬆️
unittest 95.04% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member Author

wschurman commented Feb 27, 2026

Merge activity

  • Feb 27, 2:15 AM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Feb 27, 2:21 AM UTC: Graphite rebased this pull request as part of a merge.
  • Feb 27, 2:23 AM UTC: @wschurman merged this pull request with Graphite.

@wschurman wschurman changed the base branch from wschurman/02-25-feat_support_nullable_search_fields_with_postgres_transforms to graphite-base/474 February 27, 2026 02:16
@wschurman wschurman changed the base branch from graphite-base/474 to main February 27, 2026 02:19
@wschurman wschurman force-pushed the wschurman/02-26-fix_correct_discriminated_union_type_for_forward/backward_pagination branch from f48bc26 to bf1c639 Compare February 27, 2026 02:20
@wschurman wschurman merged commit 90ae6e2 into main Feb 27, 2026
3 checks passed
@wschurman wschurman deleted the wschurman/02-26-fix_correct_discriminated_union_type_for_forward/backward_pagination branch February 27, 2026 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants