Conversation
Member
Author
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #472 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 110 110
Lines 16036 16041 +5
Branches 1439 1439
=========================================
+ Hits 16036 16041 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
f8b382e to
83e68a2
Compare
eab00ee to
6c0838d
Compare
This was referenced Feb 26, 2026
…and related methods
83e68a2 to
fa3ac1e
Compare
ide
approved these changes
Feb 26, 2026
Member
Author
Merge activity
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Why
When these were installed extension functions, we could get away without the
TMViewerContext2technique. But now that these are loader methods on thePostgresEntitysubclass, we need this again (it's the same as Entity and ReadonlyEntity).This type allows the typechecker to behave correctly when a subclass of ViewerContext is used.
How
Add generic the same as ReadonlyEntity/Entity.
Test Plan
yarn tscin application that uses ViewerContext subclass and knexLoader.