Remove Status.SUCCESS guards everywhere#678
Draft
TheJulianJES wants to merge 4 commits intozigpy:devfrom
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE
Proposed change
This removes all(!)
Status.SUCCESSchecks for zigpy requests from ZHA.ZCL errors like
Status.READ_ONLY(or possibly justStatus.FAILURE) when writing an attribute and errors likeUNSUP_CLUSTER_COMMANDdon't seem to be raised in zigpy, but instead be returned in the request result. Similar story for attribute reporting configuration and so on.As this PR removes it for everything, it definitely breaks stuff if that happens. We may be able to selectively remove guards in the platforms for now, like light.
It might be good to adjust zigpy to always raise exceptions if it doesn't get a positive response from the device.
Additional information
Related PR:
isinstanceExceptionchecks from switch #677 (<- safe)(this PR currently includes that commit)
Related discussion in: