Remove request isinstance Exception checks from switch#677
Merged
TheJulianJES merged 1 commit intozigpy:devfrom Feb 25, 2026
Merged
Remove request isinstance Exception checks from switch#677TheJulianJES merged 1 commit intozigpy:devfrom
isinstance Exception checks from switch#677TheJulianJES merged 1 commit intozigpy:devfrom
Conversation
Contributor
Author
|
Unlike #678, it is safe to just remove these two |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #677 +/- ##
=======================================
Coverage 97.51% 97.51%
=======================================
Files 62 62
Lines 10941 10941
=======================================
Hits 10669 10669
Misses 272 272 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes two dead
isinstancecheck in the switch platform. Zigpy cannot return an exception as the result here. It'll always raise instead.Another PR will remove all
Status.SUCCESSchecks for the result. We'll have to be slightly more careful with that change because ZCL errors likeUNSUPP_CLUSTER_COMMANDdon't raise(?) But they should also never occur, really.Related discussion in: