Skip to content

Remove request isinstance Exception checks from switch #677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TheJulianJES merged 1 commit into from
Feb 25, 2026
+2 −2
Merged

Remove request isinstance Exception checks from switch #677

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions zha/application/platforms/switch.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -292,15 +292,15 @@ def is_on(self) -> bool:
async def async_turn_on(self) -> None:
"""Turn the entity on."""
result = await self._on_off_cluster_handler.on()
if isinstance(result, Exception) or result[1] is not Status.SUCCESS:
if result[1] is not Status.SUCCESS:
return
self._state = True
self.maybe_emit_state_changed_event()

async def async_turn_off(self) -> None:
"""Turn the entity off."""
result = await self._on_off_cluster_handler.off()
if isinstance(result, Exception) or result[1] is not Status.SUCCESS:
if result[1] is not Status.SUCCESS:
return
self._state = False
self.maybe_emit_state_changed_event()
Expand Down
Loading