Deploy hammer and smart proxy for development#373
Deploy hammer and smart proxy for development#373adamruzicka wants to merge 10 commits intotheforeman:masterfrom
Conversation
adamruzicka
force-pushed
the
hammer-proxy-dev
branch
from
2fa6057 to
327e959
Compare
adamruzicka
left a comment
adamruzicka
left a comment
There was a problem hiding this comment.
This could possibly be made DRYer if needed. Left some comments as explanations
| foreman_remote_execution: | ||
| name: "theforeman/foreman_remote_execution" | ||
| manage_repo: true | ||
| hammer: | ||
| name: "theforeman/hammer_cli_foreman_remote_execution" | ||
| module_config: foreman_remote_execution.yml | ||
| smart_proxy: | ||
| name: "theforeman/smart_proxy_remote_execution_ssh" | ||
| module_config: remote_execution_ssh.yml |
There was a problem hiding this comment.
In the name of simplicity, this PR makes the assumption that each foreman plugin may correspond to a single hammer plugin and a single foreman-proxy plugin.
This rules out:
- standalone smart proxy plugins
- standalone hammer plugins
- odd cases where a single foreman plugin would have multiple hammer or smart proxy plugins at once
| gem: hammer_cli_foreman_ansible | ||
| name: "theforeman/hammer-cli-foreman-ansible" |
There was a problem hiding this comment.
gem needs to be provided only if it differs from the repository name
| - name: Configure smart-proxy for development | ||
| ansible.builtin.include_tasks: smart-proxy/main.yml | ||
| when: | ||
| - "'foreman-proxy' in enabled_features" | ||
|
|
||
| - name: Configure hammer for development | ||
| ansible.builtin.include_tasks: hammer/main.yml | ||
| when: | ||
| - "'hammer' in enabled_features" |
There was a problem hiding this comment.
Having these as separate roles would be cleaner, but then I couldn't reuse the plugin registry this role carries in its defaults.
There was a problem hiding this comment.
Could we split the plugin registry into a role that is mostly for meta purposes?
There was a problem hiding this comment.
Can a role access variables from a different role?
There was a problem hiding this comment.
I am sure it can, just a question of best practices....summoning @evgeni
There was a problem hiding this comment.
if you want to wait, sure, be my guest (I'll share the ale too!)
but ideally someone should have a look whether #372 is even easily usable for dev-environments
There was a problem hiding this comment.
I'd lean towards get something useful in and then refactor if it makes sense to on top of the final design. This is for development after all.
There was a problem hiding this comment.
Ack, is there anything left to be done or can we get it in as-is?
There was a problem hiding this comment.
It is green now
development/roles/foreman_development/templates/smart-proxy/settings.yml.j2
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
That's just weird becoming a directory, isn't it?..
There was a problem hiding this comment.
I'm pretty sure I noticed the wrong dir for the command and then changed something completely else...
There was a problem hiding this comment.
Do we install openscap-scanner on proxy/sat though? I thought it's for clients only..
There was a problem hiding this comment.
Iirc we do need that for format conversions
There was a problem hiding this comment.
Or at least the openscap proxy feature won't activate without it https://github.com/theforeman/smart_proxy_openscap/blob/master/lib/smart_proxy_openscap/validate_settings.rb#L6
adamruzicka
force-pushed
the
hammer-proxy-dev
branch
from
5cec284 to
e01d277
Compare
- drop --without for hammer when installing ruby dependencies - pull in development headers
adamruzicka
force-pushed
the
hammer-proxy-dev
branch
from
e01d277 to
d79a64f
Compare
adamruzicka
force-pushed
the
hammer-proxy-dev
branch
from
d79a64f to
774316d
Compare
adamruzicka
force-pushed
the
hammer-proxy-dev
branch
from
774316d to
3eccf1a
Compare
|
Could you include an update to https://github.com/theforeman/foremanctl/blob/master/docs/development-environment.md |
|
Updated the docs |
5 participants
No description provided.