Deploy hammer and smart proxy for development #373
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| --- | ||
| variables: | ||
| features: | ||
| parameter: --add-feature | ||
| help: Additional features to enable in this deployment. | ||
| action: append_unique |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,56 @@ | ||
| - name: Clone Hammer repository | ||
| ansible.builtin.git: | ||
| repo: "{{ foreman_development_hammer_git_repo }}" | ||
| dest: "{{ foreman_development_hammer_dir }}" | ||
| version: "{{ foreman_development_hammer_git_revision }}" | ||
| force: true | ||
| become: true | ||
| become_user: "{{ foreman_development_user }}" | ||
|
|
||
| - name: Add GitHub username as additional remote for Foreman | ||
| community.general.git_config: | ||
| name: "remote.{{ foreman_development_github_username }}.url" | ||
| scope: local | ||
| repo: "{{ foreman_development_hammer_dir }}" | ||
| value: "git@github.com:{{ foreman_development_github_username }}/hammer-cli.git" | ||
| state: present | ||
| become: true | ||
| become_user: "{{ foreman_development_user }}" | ||
| when: foreman_development_github_username != "" | ||
|
|
||
| - name: Setup hammer-cli-foreman | ||
| ansible.builtin.include_tasks: hammer/plugin.yml | ||
| vars: | ||
| foreman_development_plugin_name: "hammer_cli_foreman" | ||
| foreman_development_plugin_org: "theforeman" | ||
| foreman_development_plugin_repo_url: "https://github.com/theforeman/hammer-cli-foreman.git" | ||
| foreman_development_plugin_manage_repo: true | ||
| foreman_development_plugin_settings_template: "hammer/foreman.yml.j2" | ||
| foreman_development_plugin_extra_gemfiles: [] | ||
|
|
||
| - name: Setup plugins | ||
| ansible.builtin.include_tasks: hammer/plugin.yml | ||
| vars: | ||
| foreman_development_plugin_config: "{{ (foreman_development_plugin_registry[plugin_item] | default({})).hammer | default({}) }}" | ||
| foreman_development_plugin_name: "{{ foreman_development_plugin_config.name.split('/')[1] }}" | ||
| foreman_development_plugin_gem: "{{ foreman_development_plugin_config.gem }}" | ||
| foreman_development_plugin_org: "{{ foreman_development_plugin_config.name.split('/')[0] }}" | ||
| foreman_development_plugin_repo_url: "https://github.com/{{ foreman_development_plugin_config.name }}.git" | ||
| foreman_development_plugin_manage_repo: "{{ foreman_development_plugin_config.manage_repo | default(true) }}" | ||
| foreman_development_plugin_settings_template: "{{ foreman_development_plugin_config.settings_template | default('') }}" | ||
| foreman_development_plugin_module_config: "{{ foreman_development_plugin_config.module_config | default('') }}" | ||
| foreman_development_plugin_extra_gemfiles: [] | ||
| when: foreman_development_plugin_config != {} | ||
| loop: "{{ foreman_development_default_plugins + foreman_development_enabled_plugins }}" | ||
| loop_control: | ||
| loop_var: plugin_item | ||
|
|
||
| - name: Install Ruby dependencies | ||
| ansible.builtin.command: | ||
| cmd: bundle install --path .vendor --jobs 3 | ||
| chdir: "{{ foreman_development_hammer_dir }}" | ||
| become: true | ||
| become_user: "{{ foreman_development_user }}" | ||
| environment: | ||
| PATH: "/usr/bin:/bin:/usr/local/bin" | ||
| changed_when: true |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,59 @@ | ||
| --- | ||
| - name: "Clone plugin repository for {{ foreman_development_plugin_name }}" # noqa latest[git] | ||
| ansible.builtin.git: | ||
| repo: "{{ foreman_development_plugin_repo_url }}" | ||
| dest: "{{ foreman_development_deployment_dir }}/{{ foreman_development_plugin_name }}" | ||
| force: true | ||
| become: true | ||
| become_user: "{{ foreman_development_user }}" | ||
| when: foreman_development_plugin_manage_repo | ||
|
|
||
| - name: "Add GitHub username as additional remote for {{ foreman_development_plugin_name }}" | ||
| community.general.git_config: | ||
| name: "remote.{{ foreman_development_github_username }}.url" | ||
| scope: local | ||
| repo: "{{ foreman_development_deployment_dir }}/{{ foreman_development_plugin_name }}" | ||
| value: "git@github.com:{{ foreman_development_github_username }}/{{ foreman_development_plugin_name }}.git" | ||
| state: present | ||
| become: true | ||
| become_user: "{{ foreman_development_user }}" | ||
| when: | ||
| - foreman_development_plugin_manage_repo | ||
| - foreman_development_github_username != "" | ||
|
|
||
| - name: "Create settings file for {{ foreman_development_plugin_name }}" | ||
| ansible.builtin.template: | ||
| src: "{{ foreman_development_plugin_settings_template }}" | ||
| dest: "{{ foreman_development_hammer_dir }}/config/cli.modules.d/{{ foreman_development_plugin_settings_template.split('/')[1] | replace('.j2', '') }}" | ||
| owner: "{{ foreman_development_user }}" | ||
| group: "{{ foreman_development_group }}" | ||
| mode: "0644" | ||
| become: true | ||
| become_user: "{{ foreman_development_user }}" | ||
| when: foreman_development_plugin_settings_template != "" | ||
|
|
||
| - name: "Copy module config file for {{ foreman_development_plugin_name }}" | ||
| ansible.builtin.shell: | | ||
| cp {{ foreman_development_deployment_dir }}/{{ foreman_development_plugin_name }}/config/{{ foreman_development_plugin_module_config }} \ | ||
| {{ foreman_development_hammer_dir }}/config/cli.modules.d/{{ foreman_development_plugin_module_config }} | ||
| args: | ||
| creates: "{{ foreman_development_hammer_dir }}/config/cli.modules.d/{{ foreman_development_plugin_module_config }}" | ||
| become: true | ||
| become_user: "{{ foreman_development_user }}" | ||
| when: | ||
| - foreman_development_plugin_settings_template == "" | ||
| - foreman_development_plugin_module_config | default("") != "" | ||
|
|
||
| - name: "Create bundler configuration for {{ foreman_development_plugin_name }}" | ||
| ansible.builtin.lineinfile: | ||
| line: >- | ||
| gem '{{ foreman_development_plugin_gem | default(foreman_development_plugin_name) }}', | ||
| path: '{{ foreman_development_deployment_dir }}/{{ foreman_development_plugin_name }}' | ||
| path: "{{ foreman_development_hammer_dir }}/Gemfile.local.rb" | ||
| create: true | ||
| state: present | ||
| regexp: "^\\s*gem '{{ foreman_development_plugin_name }}'" | ||
| mode: "0644" | ||
| become: true | ||
| become_user: "{{ foreman_development_user }}" | ||
| when: foreman_development_plugin_name != "" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -250,3 +250,13 @@ | |
| name: foreman-development | ||
| state: stopped | ||
| enabled: false | ||
|
|
||
| - name: Configure smart-proxy for development | ||
| ansible.builtin.include_tasks: smart-proxy/main.yml | ||
| when: | ||
| - "'foreman-proxy' in enabled_features" | ||
ehelms marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| - name: Configure hammer for development | ||
| ansible.builtin.include_tasks: hammer/main.yml | ||
| when: | ||
| - "'hammer' in enabled_features" | ||
|
Comment on lines
+254
to
+262
Contributor
Author
There was a problem hiding this comment. Having these as separate roles would be cleaner, but then I couldn't reuse the plugin registry this role carries in its defaults.
Member
There was a problem hiding this comment. Could we split the plugin registry into a role that is mostly for meta purposes?
Contributor
Author
There was a problem hiding this comment. Can a role access variables from a different role?
Member
There was a problem hiding this comment. I am sure it can, just a question of best practices....summoning @evgeni
Member
Member
There was a problem hiding this comment. if you want to wait, sure, be my guest (I'll share the ale too!) but ideally someone should have a look whether #372 is even easily usable for dev-environments
Member
There was a problem hiding this comment. I'd lean towards get something useful in and then refactor if it makes sense to on top of the final design. This is for development after all.
Contributor
Author
There was a problem hiding this comment. Ack, is there anything left to be done or can we get it in as-is?
Contributor
Author
There was a problem hiding this comment. It is green now |
||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the name of simplicity, this PR makes the assumption that each foreman plugin may correspond to a single hammer plugin and a single foreman-proxy plugin.
This rules out: