Extract git repo management to a separate role#374
Merged
ehelms merged 5 commits intotheforeman:masterfrom Feb 19, 2026
Merged
Conversation
adamruzicka
commented
Feb 13, 2026
adamruzicka
force-pushed
the
git-repo
branch
from
bb964f9 to
c47e007
Compare
ehelms
reviewed
Feb 13, 2026
ehelms
reviewed
Feb 13, 2026
adamruzicka
force-pushed
the
git-repo
branch
2 times, most recently
from
1ab99f7 to
6c22577
Compare
adamruzicka
force-pushed
the
git-repo
branch
from
6c22577 to
c0f8a0b
Compare
pondrejk
approved these changes
Feb 16, 2026
ehelms
reviewed
Feb 16, 2026
ehelms
reviewed
Feb 16, 2026
ehelms
reviewed
Feb 16, 2026
ehelms
reviewed
Feb 16, 2026
ehelms
reviewed
Feb 16, 2026
| | `git_repository_destination_dir` | Path to the directory where the repository will be cloned to | Yes | | ||
| | `git_repository_secondary_remote_owner` | Name of the owner of the secondary remote to be added to the local clone | No, secondary remote will not be added if left blank | | ||
| | `git_repository_secondary_remote_name` | Name of the remote of the secondary repository | No, defaults to `{{ git_repository_secondary_remote_owner }}` | | ||
| | `git_repository_user` | The owner of the git checkout | Yes | |
Member
There was a problem hiding this comment.
Maybe mention that this is the system user?
ehelms
approved these changes
Feb 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This consolidates the behaviour in one place (currently there are two uses, #373 will add another four, if accepted). The default behavour should be the same as before, but this should allow us to do some extra things.
The extras:
On the machine
When deploying stuff myself I usually use
upstreamremote for thetheforemanrepositories andoriginfor my fork. If I occasionally add someone else's remote, then I use their handle. The current way oftheforemanrepositories beingoriginand my forks beingadamruzickathrows me off for two reasons - muscle memory is strong and my github handle is way too long.