-
-
Notifications
You must be signed in to change notification settings - Fork 0
Fix CI: switch to pnpm for workspace protocol support #155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix CI: switch to pnpm for workspace protocol support #155
Conversation
- Add packageManager field to package.json (pnpm@9.15.1) - Create pnpm-workspace.yaml for monorepo configuration - Update CI workflow to use pnpm instead of npm - Enable Corepack in CI workflow - Remove package-lock.json, add pnpm-lock.yaml - Fixes EUNSUPPORTEDPROTOCOL error with workspace:* dependencies Co-authored-by: kayodebristol <3579196+kayodebristol@users.noreply.github.com>
|
CI failed on this branch (workflow_dispatch run 21645706378) due to TypeScript typecheck errors:
@copilot please patch these on this PR branch (keep scope minimal), push, and re-run CI. Once checks are green we can squash-merge. |
- Remove unused import 'path' from conversations.ts - Add null check for classification.confidence - Filter undefined values from labels array - Prefix unused parameter with underscore in gateNotDuplicate - Explicitly type 'passed' as boolean in gateHasMetadata - Prefix unused parameter with underscore in normalizeCodeBlocks Fixes all 6 TypeScript errors blocking CI Co-authored-by: kayodebristol <3579196+kayodebristol@users.noreply.github.com>
Fixed in 6cf3f48. All 6 TypeScript errors resolved:
Typecheck, build, and tests all pass locally. CI should be green now. |
|
@copilot Please fix failing CI for this PR. Steps:
Failing checks summary (from When done, comment what changed and why. |
All fixes are already in place (commit 6cf3f48). Verified locally: ✅ Issue: CI hasn't run on the latest commit because the workflow triggers only on The branch is ready to merge - all checks pass locally. |
d7dcafb
into
dependabot/github_actions/actions/upload-artifact-6
* chore(deps): bump actions/upload-artifact from 4 to 6 Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 4 to 6. - [Release notes](https://github.com/actions/upload-artifact/releases) - [Commits](actions/upload-artifact@v4...v6) --- updated-dependencies: - dependency-name: actions/upload-artifact dependency-version: '6' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> * Fix CI: switch to pnpm for workspace protocol support (#155) * Initial plan * fix: switch from npm to pnpm for workspace support - Add packageManager field to package.json (pnpm@9.15.1) - Create pnpm-workspace.yaml for monorepo configuration - Update CI workflow to use pnpm instead of npm - Enable Corepack in CI workflow - Remove package-lock.json, add pnpm-lock.yaml - Fixes EUNSUPPORTEDPROTOCOL error with workspace:* dependencies Co-authored-by: kayodebristol <3579196+kayodebristol@users.noreply.github.com> * fix: resolve TypeScript typecheck errors - Remove unused import 'path' from conversations.ts - Add null check for classification.confidence - Filter undefined values from labels array - Prefix unused parameter with underscore in gateNotDuplicate - Explicitly type 'passed' as boolean in gateHasMetadata - Prefix unused parameter with underscore in normalizeCodeBlocks Fixes all 6 TypeScript errors blocking CI Co-authored-by: kayodebristol <3579196+kayodebristol@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: kayodebristol <3579196+kayodebristol@users.noreply.github.com> --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com> Co-authored-by: kayodebristol <3579196+kayodebristol@users.noreply.github.com>
Plan to Fix CI Failures
workspace:*protocol requires pnpm, but workflow uses npm✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.