Fix CI: migrate npm to pnpm for workspace:* protocol support #153
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
This PR is currently Draft. Minimal next steps:
Once checks are green + required reviews are satisfied, we can squash merge. |
- Enable Corepack and configure pnpm in CI workflow - Add pnpm-workspace.yaml for workspace configuration - Generate pnpm-lock.yaml for dependency locking - Update all workflow commands to use pnpm instead of npm - Fix TypeScript errors that surfaced after fixing dependencies: - Remove unused 'path' import in conversations.ts - Add nullish coalescing for optional confidence field - Fix type filtering for labels array - Prefix unused parameters with underscore - Add explicit boolean type conversions Co-authored-by: kayodebristol <3579196+kayodebristol@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update actions/upload-artifact from version 4 to 6
Fix CI: migrate npm to pnpm for workspace:* protocol support
Feb 3, 2026
Contributor
|
Closing as superseded by #155 (single consolidated fix for the Node 18/20 CI + workspace:* issue). If we need to resurrect any approach from this PR, we can reopen. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CI was failing on dependency installation because the workflow used npm, but package.json dependencies use
workspace:*protocol (pnpm-only).Workflow changes:
npm ci→pnpm install --frozen-lockfileWorkspace config:
pnpm-workspace.yamldefining workspace packagespnpm-lock.yamlfor reproducible installsTypeScript fixes:
Pre-existing type errors surfaced once deps installed successfully:
classification.confidence_💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.