-
-
Notifications
You must be signed in to change notification settings - Fork 0
Fix CI failure: migrate from npm to pnpm workspace #149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix CI failure: migrate from npm to pnpm workspace #149
Conversation
- Add pnpm-workspace.yaml configuration - Generate pnpm-lock.yaml - Remove package-lock.json (npm is incompatible with workspace: protocol) - Add packageManager field to package.json specifying pnpm@10.28.2 - Update CI workflow to use pnpm with Corepack - Enable Corepack in CI before setup-node - Change cache from 'npm' to 'pnpm' - Replace npm commands with pnpm equivalents Co-authored-by: kayodebristol <3579196+kayodebristol@users.noreply.github.com>
- Update publish.yml to use pnpm for npm publishing - Update release.yml to use pnpm for building and testing - Update azure-functions.yml to use pnpm for Azure deployments - Add Corepack enablement and pnpm cache to all workflows Co-authored-by: kayodebristol <3579196+kayodebristol@users.noreply.github.com>
- Replace npm install/run/test commands with pnpm equivalents - Update development setup instructions - Update example running instructions - Update dogfooding workflow documentation Co-authored-by: kayodebristol <3579196+kayodebristol@users.noreply.github.com>
Remove unsafe --no-git-checks flag that bypasses git repository validation during publishing. Co-authored-by: kayodebristol <3579196+kayodebristol@users.noreply.github.com>
|
Draft PR noted by automated sweep. If this is ready, mark it Ready for review; otherwise please add the remaining checklist items/blockers. [@copilot] can help finalize when ready. |
This PR is ready for review. All work is complete: ✅ Root cause fixed: migrated from npm to pnpm (commits 1483cf6-a0a4547) The changes fix the CI failure on the base branch where |
|
This PR is currently Draft.\n\nMinimal next steps:\n- Mark as Ready for review when safe\n- Ensure CI is green\n- Request review / address feedback\n\nOnce checks are green + required reviews are satisfied, we can squash merge. |
|
This PR is currently Draft. Minimal next steps:
Once checks are green + required reviews are satisfied, we can squash merge. |
|
Closing as superseded by #155 (single consolidated fix for the Node 18/20 CI + workspace:* issue). If we need to resurrect any approach from this PR, we can reopen. |
The repository uses pnpm's
workspace:*protocol for internal dependencies, but CI workflows were configured for npm, which doesn't support this protocol. This causednpm cito fail withUnsupported URL Type "workspace:".Changes
Package manager configuration:
pnpm-workspace.yamlandpnpm-lock.yamlpackage-lock.jsonpackageManager: "pnpm@10.28.2"to package.jsonCI workflows (.github/workflows/):
npmtopnpmnpm ci→pnpm install --frozen-lockfilenpm run→pnpm runUpdated workflows:
ci.yml,publish.yml,release.yml,azure-functions.ymlDocumentation:
Example workspace dependency
{ "dependencies": { "@plures/praxis-core": "workspace:*" } }This syntax requires pnpm; npm treats it as an invalid protocol.
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.