Skip to content

refactor: Refactor #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jylamont merged 1 commit into from
Feb 25, 2025
Merged

refactor: Refactor #88

jylamont merged 1 commit into from
Feb 25, 2025

Conversation

@jylamont
Copy link
Contributor

@jylamont jylamont commented Feb 24, 2025 •
edited
Loading

This PR improves the Vero gem's code organization and maintainability.

  • Created a base sender class with shared functionality
  • Updated all sender implementations (DelayedJob, Resque, Sidekiq, SuckerPunch) to inherit from this base class
  • Improved error handling and logging
  • Modernized Rspec usage, test organization and removed duplicated code
  • Fixed potential security issues by using public_send instead of send
  • Made error messages more descriptive

This was referenced Feb 24, 2025
Merged
Merged
Merged
Merged
Merged
@jylamont Graphite App
Copy link
Contributor Author

jylamont commented Feb 24, 2025 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

This was referenced Feb 24, 2025
Merged
Open
Merged
@jylamont jylamont force-pushed the 02-21-refactor_refactor branch from 89cf450 to fe85416 Compare February 24, 2025 14:56
@jylamont jylamont marked this pull request as ready for review February 24, 2025 14:59
@jylamont jylamont force-pushed the 02-21-refactor_refactor branch from fe85416 to 801ef51 Compare February 24, 2025 14:59
@jylamont jylamont force-pushed the feature/rest_client_timeout branch from f27cb15 to 3cc33b1 Compare February 24, 2025 15:17
@jylamont jylamont force-pushed the 02-21-refactor_refactor branch from 801ef51 to 13ff379 Compare February 24, 2025 15:18
@jylamont jylamont force-pushed the feature/rest_client_timeout branch from 3cc33b1 to 9a98116 Compare February 24, 2025 15:23
@jylamont jylamont force-pushed the 02-21-refactor_refactor branch from 13ff379 to 4b753e0 Compare February 24, 2025 15:23
@jylamont jylamont changed the base branch from feature/rest_client_timeout to graphite-base/88 February 24, 2025 15:23
@jylamont jylamont force-pushed the 02-21-refactor_refactor branch from 4b753e0 to 9d5158f Compare February 24, 2025 15:23
@jylamont jylamont changed the base branch from graphite-base/88 to master February 24, 2025 15:24
@jylamont jylamont force-pushed the 02-21-refactor_refactor branch from 9d5158f to 913e239 Compare February 24, 2025 15:24
@jylamont jylamont changed the base branch from master to graphite-base/88 February 24, 2025 15:48
@jylamont jylamont force-pushed the 02-21-refactor_refactor branch from 913e239 to f340488 Compare February 24, 2025 15:49
@jylamont jylamont changed the base branch from graphite-base/88 to 02-24-bug_fixed_restclient_logger_issue February 24, 2025 15:49
This was referenced Feb 24, 2025
Merged
Open
@jylamont jylamont force-pushed the 02-24-bug_fixed_restclient_logger_issue branch from 18f8400 to b0ef065 Compare February 24, 2025 17:39
@jylamont jylamont force-pushed the 02-21-refactor_refactor branch from f340488 to db57f51 Compare February 24, 2025 17:39
@jylamont jylamont mentioned this pull request Feb 24, 2025
Open
@jylamont jylamont force-pushed the 02-21-refactor_refactor branch from db57f51 to bac9ac2 Compare February 24, 2025 23:28
@jylamont jylamont force-pushed the 02-21-refactor_refactor branch 3 times, most recently from f8f4c2f to 605307f Compare February 25, 2025 17:41
@jylamont Graphite App
Copy link
Contributor Author

jylamont commented Feb 25, 2025 •
edited
Loading

Merge activity

  • Feb 25, 12:49 PM EST: A user started a stack merge that includes this pull request via Graphite.
  • Feb 25, 12:51 PM EST: Graphite rebased this pull request as part of a merge.
  • Feb 25, 12:53 PM EST: A user merged this pull request with Graphite.

@jylamont jylamont changed the base branch from 02-24-bug_fixed_restclient_logger_issue to graphite-base/88 February 25, 2025 17:49
@jylamont jylamont changed the base branch from graphite-base/88 to master February 25, 2025 17:50
@jylamont jylamont force-pushed the 02-21-refactor_refactor branch from 605307f to ce14a24 Compare February 25, 2025 17:51
@jylamont jylamont merged commit 0f63485 into master Feb 25, 2025
8 checks passed
@jylamont jylamont deleted the 02-21-refactor_refactor branch February 25, 2025 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jylamont