improve: Added Github Action CI #78
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 17, 2024
Merged
Contributor
Author
This was referenced Apr 17, 2024
Merged
jylamont
force-pushed
the
04-17-improve_added_github_action_ci
branch
from
939b9aa to
ea3dfee
Compare
edubkendo
approved these changes
Apr 17, 2024
edubkendo
left a comment
edubkendo
left a comment
There was a problem hiding this comment.
Looks good! It's a shame there's no way to just hand circleCI a list of ruby versions and then write the boilerplate for running specs once.
Contributor
Author
|
Good point @edubkendo, there very likely is. I'll take a look before merging. |
jylamont
force-pushed
the
04-17-improve_added_github_action_ci
branch
from
ea3dfee to
e4579a9
Compare
Contributor
Author
jylamont
force-pushed
the
04-17-chore_run_rubocop_over_existing_code
branch
from
dc29935 to
a35b33a
Compare
Base automatically changed from
04-17-chore_run_rubocop_over_existing_code
to
master
April 18, 2024 00:09
jylamont
force-pushed
the
04-17-improve_added_github_action_ci
branch
from
e4579a9 to
a3c498e
Compare
This was referenced Feb 24, 2025
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We previously used TravisCI to run specs. This PR replaces this with a Github Action. It also removes the version locks on development dependencies as they are very old.