bug: Fixes Sidekiq Worker issue w/ strict args #93
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 24, 2025
Merged
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
jylamont
force-pushed
the
02-24-bug_fixes_sidekiq_worker_issue_w__strict_args
branch
2 times, most recently
from
346cebb to
a06b651
Compare
jylamont
force-pushed
the
02-24-bug_fixes_sidekiq_worker_issue_w__strict_args
branch
from
a06b651 to
986961f
Compare
jylamont
force-pushed
the
02-21-improve_only_load_async_workers_if_deps_available
branch
from
a722f66 to
cf891bb
Compare
jylamont
force-pushed
the
02-24-bug_fixes_sidekiq_worker_issue_w__strict_args
branch
2 times, most recently
from
47ee8cc to
2806193
Compare
jylamont
force-pushed
the
02-21-improve_only_load_async_workers_if_deps_available
branch
from
cf891bb to
0df5db5
Compare
jylamont
force-pushed
the
02-21-improve_only_load_async_workers_if_deps_available
branch
from
0df5db5 to
d3a290c
Compare
jylamont
force-pushed
the
02-24-bug_fixes_sidekiq_worker_issue_w__strict_args
branch
from
2806193 to
68e311c
Compare
jylamont
changed the base branch from
02-21-improve_only_load_async_workers_if_deps_available
to
graphite-base/93
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #79. Sidekiq 7+ validates that workers args will safely serialize to JSON, meaning symbol keys are no longer allowed.