Add support for variable time deltas#30
Draft
mtilda wants to merge 5 commits intobraincore:masterfrom
Draft
Conversation
Collaborator
Author
|
Checkout mtilda#2 to see how we might add a feature flag. |
Owner
|
I agree with not breaking the existing signature for How about you rename your new function to:
And it can simply coexist? |
dt argument to Pid::next_control_output()|
This would be a super-nice addition to the crate! Hoping this can be merged soon, thanks for your work! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
We add a new method
Pid::next_control_output_with_dt()which handles a variable time delta (dt).The new method is called internally by
Pid::next_control_output().To do
pid-rs/README.md
Line 73 in 55f0ee2
dt.