Rename MaxBinning to MaxHwBinning #1397
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 22, 2025
Merged
agalasso
force-pushed
the
andy/guider-CurrentImage-is-never-null
branch
from
f965bde to
853d2a3
Compare
agalasso
force-pushed
the
andy/rename-MaxBinning-to-MaxHwBinning
branch
from
bf8cf62 to
b75d67f
Compare
bwdev01
reviewed
Dec 23, 2025
Contributor
bwdev01
left a comment
bwdev01
left a comment
There was a problem hiding this comment.
I don't know what happens downstream but places like the GA, CalstepDialog, and ProfileWiz are going to want to deal with total binning not just hw-supported.
Contributor
Author
Good observation. You should be able to see that play out in the following PRs, especially #1414. If you want see the final result, you can look at the final code in #1414's branch This PR has only the one variable rename so we can see in isolation that it does no harm. |
bwdev01
approved these changes
Dec 23, 2025
agalasso
force-pushed
the
andy/guider-CurrentImage-is-never-null
branch
from
853d2a3 to
ec2dda0
Compare
agalasso
force-pushed
the
andy/rename-MaxBinning-to-MaxHwBinning
branch
from
b75d67f to
abe2ce9
Compare
agalasso
force-pushed
the
andy/guider-CurrentImage-is-never-null
branch
from
ec2dda0 to
51b54b8
Compare
Base automatically changed from
andy/guider-CurrentImage-is-never-null
to
master
December 31, 2025 22:07
In preparation for introducing software binning, rename MaxBinning to MaxHwBinning to be more specific about the meaning. No functional changes in this PR, just the member variable name change.
agalasso
force-pushed
the
andy/rename-MaxBinning-to-MaxHwBinning
branch
from
abe2ce9 to
c2bd2ce
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename MaxBinning to MaxHwBinning
In preparation for introducing software binning #738, rename MaxBinning to
MaxHwBinning to be more specific about the meaning.
No functional changes in this PR, just the member variable name change.