Add support for software binning. #1414
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agalasso
force-pushed
the
andy/software-binning-support
branch
2 times, most recently
from
bfb3cae to
b6be1fd
Compare
agalasso
force-pushed
the
andy/binning-options-do-not-assume-consecutive-ints
branch
from
8e0843e to
584c9b2
Compare
agalasso
force-pushed
the
andy/software-binning-support
branch
from
b6be1fd to
c2b2cb3
Compare
agalasso
force-pushed
the
andy/binning-options-do-not-assume-consecutive-ints
branch
from
584c9b2 to
ac51654
Compare
agalasso
force-pushed
the
andy/software-binning-support
branch
from
c2b2cb3 to
4fb7d89
Compare
agalasso
force-pushed
the
andy/binning-options-do-not-assume-consecutive-ints
branch
from
ac51654 to
d2b2f61
Compare
agalasso
force-pushed
the
andy/software-binning-support
branch
from
4fb7d89 to
778d4b7
Compare
This was referenced Dec 23, 2025
agalasso
force-pushed
the
andy/binning-options-do-not-assume-consecutive-ints
branch
from
d2b2f61 to
992bb31
Compare
agalasso
force-pushed
the
andy/software-binning-support
branch
from
778d4b7 to
4ccec25
Compare
agalasso
force-pushed
the
andy/binning-options-do-not-assume-consecutive-ints
branch
from
992bb31 to
b3ea3f7
Compare
agalasso
force-pushed
the
andy/software-binning-support
branch
from
4ccec25 to
47e5cb4
Compare
agalasso
force-pushed
the
andy/binning-options-do-not-assume-consecutive-ints
branch
from
b3ea3f7 to
276d1d6
Compare
agalasso
force-pushed
the
andy/software-binning-support
branch
from
47e5cb4 to
8013c33
Compare
bwdev01
reviewed
Dec 31, 2025
Contributor
bwdev01
left a comment
bwdev01
left a comment
There was a problem hiding this comment.
Why is the software binning code housed in the .h file rather than in image_math.cpp?
bwdev01
approved these changes
Dec 31, 2025
Contributor
Author
C++ -ism: templates need to be included (typically via a .h) to be instantiated. |
agalasso
force-pushed
the
andy/binning-options-do-not-assume-consecutive-ints
branch
from
276d1d6 to
c9e2481
Compare
Base automatically changed from
andy/binning-options-do-not-assume-consecutive-ints
to
master
December 31, 2025 22:10
Needs additional work to add a UI to actually enable sw binning. Tested with simulator and ZWO ASI camera.
agalasso
force-pushed
the
andy/software-binning-support
branch
from
8013c33 to
5704847
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for software binning #738.
Needs additional work to add a UI to actually enable sw binning.
Tested with simulator and ZWO ASI camera.