Fix assumption that binning choices are consecutive int values. #1413
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agalasso
force-pushed
the
andy/unreachable-code
branch
from
b14b68c to
513517a
Compare
agalasso
force-pushed
the
andy/binning-options-do-not-assume-consecutive-ints
branch
from
8e0843e to
584c9b2
Compare
agalasso
force-pushed
the
andy/unreachable-code
branch
from
513517a to
ffbc498
Compare
agalasso
force-pushed
the
andy/binning-options-do-not-assume-consecutive-ints
branch
from
584c9b2 to
ac51654
Compare
agalasso
force-pushed
the
andy/unreachable-code
branch
from
ffbc498 to
a568ae7
Compare
agalasso
force-pushed
the
andy/binning-options-do-not-assume-consecutive-ints
branch
from
ac51654 to
d2b2f61
Compare
bwdev01
reviewed
Dec 23, 2025
Contributor
bwdev01
left a comment
bwdev01
left a comment
There was a problem hiding this comment.
Can't these non-null checks on m_binning be removed as in the previous PR? Long ago, we didn't create various controls if the camera didn't support them but this was error-prone with "omnibus" drivers. So now we always create the controls and just disable them if the device doesn't support them (late-binding)
bwdev01
approved these changes
Dec 23, 2025
Contributor
Author
Good point. Made #1420 to fix it. |
agalasso
force-pushed
the
andy/unreachable-code
branch
from
a568ae7 to
7e42e41
Compare
agalasso
force-pushed
the
andy/binning-options-do-not-assume-consecutive-ints
branch
2 times, most recently
from
992bb31 to
b3ea3f7
Compare
agalasso
force-pushed
the
andy/unreachable-code
branch
from
7e42e41 to
cc12873
Compare
agalasso
force-pushed
the
andy/binning-options-do-not-assume-consecutive-ints
branch
from
b3ea3f7 to
276d1d6
Compare
agalasso
force-pushed
the
andy/unreachable-code
branch
from
cc12873 to
f6a0780
Compare
When software binning is added, there may be gaps in the list of allowed binning levels.
agalasso
force-pushed
the
andy/binning-options-do-not-assume-consecutive-ints
branch
from
276d1d6 to
c9e2481
Compare
agalasso
deleted the
andy/binning-options-do-not-assume-consecutive-ints
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix assumption that binning choices are consecutive int values.
When software binning is added #738, there may be gaps in the list of allowed binning
levels.