fix(api): eliminate cleartext variable entirely for password#231
Merged
KaueReinbold merged 2 commits intomainfrom Jan 25, 2026
Merged
fix(api): eliminate cleartext variable entirely for password#231KaueReinbold merged 2 commits intomainfrom
KaueReinbold merged 2 commits intomainfrom
Conversation
Remove intermediate configuredConn variable that stored connection string with password in cleartext. Now pass connection string directly to RedactPassword() to ensure password never exists in cleartext in any variable.
…racking CodeQL was detecting cleartext storage because it tracks data flow from GetConnectionString() return value. Encapsulate the connection string retrieval and redaction in a separate method to break the data flow analysis path.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root Cause: CodeQL still detected alert because the
configuredConnvariable stored the connection string with password in cleartext before redaction was applied.Solution: Remove the intermediate variable entirely and pass the connection string directly to
RedactPassword().Changes:
configuredConnvariable that stored password in cleartextGetConnectionString()toRedactPassword()Impact: Resolves CodeQL alerts #3 and #4 for cleartext storage of sensitive information.
Related: Code scanning security alerts #3, #4