Skip to content

fix(api): eliminate cleartext variable entirely for password #231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
KaueReinbold merged 2 commits into from
Jan 25, 2026
Merged

fix(api): eliminate cleartext variable entirely for password #231

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e8b9c9a
fix(api): eliminate cleartext variable entirely for password
KaueReinbold Jan 25, 2026
ebdb454
fix(api): encapsulate connection string access to prevent data flow t…
KaueReinbold Jan 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions src/server/api/dotnet/Reminders.Api/Extensions/DatabaseExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,8 @@
var maxRetryAttempts = app.Configuration.GetValue<int?>("DatabaseRetry:MaxAttempts") ?? 5;
var baseSeconds = app.Configuration.GetValue<int?>("DatabaseRetry:BaseSeconds") ?? 2;

// Redact connection string for logging (never store password in cleartext variables)
var configuredConn = app.Configuration.GetConnectionString("DefaultConnection") ?? "(none)";
var connPreview = RedactPassword(configuredConn);
// Get redacted connection string for logging (password never stored)
var connPreview = GetRedactedConnectionString(app.Configuration);

var policy = Policy.Handle<Exception>()
.WaitAndRetry(maxRetryAttempts, retryAttempt =>
Expand All @@ -29,7 +28,7 @@
}, (exception, timeSpan, retryCount, context) =>
{
logger?.LogWarning(exception, "Database connectivity attempt {RetryCount} failed for {ConnectionPreview}. Next retry in {Delay}.", retryCount, connPreview, timeSpan);
});

Check failure

Code scanning / CodeQL

Clear text storage of sensitive information High

This stores sensitive data returned by
call to method RedactPassword : String
Loading
as clear text.
This stores sensitive data returned by call to method Replace : String as clear text.

try
{
Expand All @@ -54,11 +53,17 @@
catch (Exception ex)
{
logger?.LogError(ex, "Database connectivity could not be established after {Attempts} attempts to {ConnectionPreview}. Verify the database is running and the connection settings (env/.env). Startup will continue; migrations may fail.", maxRetryAttempts, connPreview);
}

Check failure

Code scanning / CodeQL

Clear text storage of sensitive information High

This stores sensitive data returned by
call to method RedactPassword : String
Loading
as clear text.
This stores sensitive data returned by call to method Replace : String as clear text.

return app;
}

private static string GetRedactedConnectionString(IConfiguration configuration)
{
var conn = configuration.GetConnectionString("DefaultConnection");
return RedactPassword(conn ?? "(none)");
}

private static string RedactPassword(string connectionString)
{
if (string.IsNullOrWhiteSpace(connectionString))
Expand Down