fix(api): remove connection string from logs entirely#232
Merged
KaueReinbold merged 2 commits intomainfrom Jan 25, 2026
Merged
Conversation
Remove all connection string references from logs to eliminate
any potential exposure of sensitive information. Logs now only
show generic retry messages without database connection details.
Changes:
- Removed GetRedactedConnectionString() helper method
- Removed RedactPassword() helper method
- Updated log messages to exclude connection string preview
- Logs now show: 'Database connectivity attempt {RetryCount} failed'
Resolves CodeQL cleartext storage alerts by not logging connection
string at all, even in redacted form.
Also remove connection string logging from MigrationsRunner service
to maintain consistency across all services.
Changes:
- Removed RedactConnectionString() helper method
- Updated startup log to only show provider name
- Log now shows: 'Migration runner starting with provider: {Provider}'
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem: Previous attempts to redact passwords in connection strings still triggered CodeQL alerts because it tracks data flow from
GetConnectionString().Solution: Remove connection string logging entirely. No need to log database connection details - generic error messages are sufficient.
Changes:
GetRedactedConnectionString()helper methodRedactPassword()helper methodBefore:
After:
Impact:
Supersedes PRs #230 and #231 which attempted redaction but CodeQL still detected data flow.