Skip to content

getblock RPC#2291

Merged
prasannavl merged 17 commits intomasterfrom
pvl/rewards-getblock-refactor
Aug 7, 2023
Merged

getblock RPC#2291
prasannavl merged 17 commits intomasterfrom
pvl/rewards-getblock-refactor

Conversation

@prasannavl
Copy link
Contributor

@prasannavl prasannavl commented Aug 6, 2023

Summary

  • Introudces MinterInfo and RewardsInfo structs to isolate logic from JSON in getblockRPC
  • Accept verbosity > 2 mode which is a cleaned up version of the RPC without polluting Bitcoin's output schema.
  • Cleans up coinbase rewards on Connect and Disconnect to be more comprehensible and maintainable.
    • More work needed to move them into structures similar to RewardsInfo later.
  • Adds coinbase info to getblock as well, including XVM structures

RPCs

  • getblock: Adds verbosity level 3, 4.

Implications

  • Storage

    • Database reindex required
    • Database reindex optional
    • Database reindex not required
    • None
  • Consensus

    • Network upgrade required
    • Includes backward compatible changes
    • Includes consensus workarounds
    • Includes consensus refactors
    • None

@prasannavl prasannavl mentioned this pull request Aug 6, 2023
9 tasks
@Bushstar Bushstar added ci/sync and removed ci/sync labels Aug 7, 2023
@Bushstar Bushstar changed the title Cleanup Coinbase rewards, getblock RPC getblock RPC Aug 7, 2023
@prasannavl
Copy link
Contributor Author

Consensus refactors pulled out to #2295

@prasannavl prasannavl merged commit aa90c87 into master Aug 7, 2023
@prasannavl prasannavl deleted the pvl/rewards-getblock-refactor branch August 7, 2023 12:38
@prasannavl prasannavl mentioned this pull request Aug 7, 2023
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants