Skip to content

Clean up unsafe usages, tweak rust naming#2294

Merged
prasannavl merged 27 commits intomasterfrom
pvl/unsafe-rs
Aug 7, 2023
Merged

Clean up unsafe usages, tweak rust naming#2294
prasannavl merged 27 commits intomasterfrom
pvl/unsafe-rs

Conversation

@prasannavl
Copy link
Contributor

@prasannavl prasannavl commented Aug 7, 2023

Summary

  • Aims to mark items that cross lang boundaries and require locking context as unsafe to get help from the compiler to avoid accidental usages on the Rust side, and unsure usage on the C++ side.

Based on: #2291

Implications

  • Storage

    • Database reindex required
    • Database reindex optional
    • Database reindex not required
    • None
  • Consensus

    • Network upgrade required
    • Includes backward compatible changes
    • Includes consensus workarounds
    • Includes consensus refactors
    • None

@prasannavl prasannavl marked this pull request as ready for review August 7, 2023 08:44
@prasannavl prasannavl merged commit 30ee320 into master Aug 7, 2023
@prasannavl prasannavl deleted the pvl/unsafe-rs branch August 7, 2023 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants