Skip to content

Normalize ERC55 terminology#2293

Merged
prasannavl merged 27 commits intomasterfrom
pvl/erc55-normalize
Aug 8, 2023
Merged

Normalize ERC55 terminology#2293
prasannavl merged 27 commits intomasterfrom
pvl/erc55-normalize

Conversation

@prasannavl
Copy link
Contributor

@prasannavl prasannavl commented Aug 6, 2023

Summary

  • Normalizes terminology to ERC55
  • Allow listing normal balances in ERC55
    • Restored to not show ERC55 in listreceivedby, as it's not allowed on mainnet due to non-standard TX
    • For other networks, we should still flag it later to enable on RPC. But leaving it for now to add it later.

Based on #2291

RPC

  • getaccount:
    • Changed include_eth to evm.
    • Note that this only includes EVM native (DFI) balance. Does not include DST20.

Implications

  • Storage

    • Database reindex required
    • Database reindex optional
    • Database reindex not required
    • None
  • Consensus

    • Network upgrade required
    • Includes backward compatible changes
    • Includes consensus workarounds
    • Includes consensus refactors
    • None

@prasannavl prasannavl requested a review from Bushstar August 7, 2023 17:07
Bushstar
Bushstar previously approved these changes Aug 8, 2023
@prasannavl prasannavl merged commit e9a6ccb into master Aug 8, 2023
@prasannavl prasannavl deleted the pvl/erc55-normalize branch August 8, 2023 12:38
@prasannavl prasannavl changed the title Normalize ERC55 terminology and enable listing received Normalize ERC55 terminology Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants