add build info section in manifest (port changes from PR #111) #112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ch.zhou <chong.zhou@broadcom.com>
1000TurquoisePogs
requested changes
Aug 1, 2025
Member
1000TurquoisePogs
left a comment
1000TurquoisePogs
left a comment
There was a problem hiding this comment.
This does not work.
The output produces a manifest which says
build:
branch: "{{build.branch}}"
number: "{{build.number}}"
commitHash: "{{build.commitHash}}"
timestamp: {{build.timestamp}}
That is, the templates are not filled in.
This is because the github workflow probably does not do anything with that information.
github-project-automation
bot
moved this from Ready for Review
to Change Requested
in WebUI planning board
Author
|
@1000TurquoisePogs Hi, thanks for the comment. I believe it was because the PR-46 for zowe-actions/zlux-builds had not been merged when you observed the problem 3 days ago. I reran the build workflow just now and the new result package has the build information in the manifest.json. |
15 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port changes from PR #111 for v2.x/staging
The fix enables the zowe-actions/zlux-builds/plugins/prepare-workflow to generate build information in the manifest.yaml.