Skip to content

Conversation

@ChongZhou-Broadcom
Copy link

@ChongZhou-Broadcom ChongZhou-Broadcom commented Jun 30, 2025

Proposed changes

This PR addresses Issue: [Link to Github issue within https://github.com/zowe/zlux/issues if any]

n/a

This PR depends upon the following PRs:

zowe-actions/zlux-builds/pull/45

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Change in a documentation
  • Refactor the code
  • Chore, repository cleanup, updates the dependencies.
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

PR Checklist

Please delete options that are not relevant.

  • If the changes in this PR are meant for the next release / mainline, this PR targets the "staging" branch.
  • My code follows the style guidelines of this project (see: Contributing guideline)
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (n/a)
  • New and existing unit tests pass locally with my changes (n/a)
  • video or image is included if visual changes are made (n/a)
  • Relevant update to CHANGELOG.md (n/a)
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works, or describe a test method below (n/a)

Testing

n/a

Further comments

The fix enables the zowe-actions/zlux-builds/plugins/prepare-workflow to generate build information in the manifest.yaml.

VERSION: 2.0.2
CHANGELOG: Bugfix: Generate build information in manifest.

Copy link
Member

@1000TurquoisePogs 1000TurquoisePogs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not work.
The output produces a manifest which says

build:
  branch: "{{build.branch}}"
  number: "{{build.number}}"
  commitHash: "{{build.commitHash}}"
  timestamp: {{build.timestamp}}

That is, the templates are not filled in.
This is because the github workflow probably does not do anything with that information.

@github-project-automation github-project-automation bot moved this from Ready for Review to Change Requested in WebUI planning board Aug 1, 2025
@ChongZhou-Broadcom
Copy link
Author

ChongZhou-Broadcom commented Aug 4, 2025

@1000TurquoisePogs Hi, unlike the PR #112 for v2.x/staging, this PR's problem is not with the code change that I made. The problem is the build action is no longer working, the whole workflow stops at the npm ci step, and so the result package is no longer produced. I tried to fix the problem, however I only made it work on my laptop with a lot of modifications in the package.json but finally I failed to make it work in the Github's worker node before I stopped.

I guess you have already noticed this problem when you were running this job last week.

I am hesitating if I should find someone who is in charge of the sample apps or I should create another PR to fix it on my own. Any thoughts? Thanks.

The templates are not filled in because no new package was created at all. I tried to run the workflow but it no longer works for v3.x-based branches. It does not work for this PR, and it not work for v3.x/staging either.

I tried to fix it but it seems to need some bigger updates. I am not a web GUI developer so I have to create an issue and wait for experienced guys to fix it.

So we will have to put this PR on hold for now. Once v3.x/staging can be built by the workflow, I will rebase this branch.

Signed-off-by: ch.zhou <chong.zhou@broadcom.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: Change Requested

Development

Successfully merging this pull request may close these issues.

3 participants