-
Notifications
You must be signed in to change notification settings - Fork 16
add build info section in manifest #111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: v3.x/staging
Are you sure you want to change the base?
Conversation
e7f16fd to
34dfdce
Compare
1000TurquoisePogs
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This does not work.
The output produces a manifest which says
build:
branch: "{{build.branch}}"
number: "{{build.number}}"
commitHash: "{{build.commitHash}}"
timestamp: {{build.timestamp}}
That is, the templates are not filled in.
This is because the github workflow probably does not do anything with that information.
|
@1000TurquoisePogs
The templates are not filled in because no new package was created at all. I tried to run the workflow but it no longer works for v3.x-based branches. It does not work for this PR, and it not work for I tried to fix it but it seems to need some bigger updates. I am not a web GUI developer so I have to create an issue and wait for experienced guys to fix it. So we will have to put this PR on hold for now. Once |
Signed-off-by: ch.zhou <chong.zhou@broadcom.com>
34dfdce to
286bb30
Compare
db93371 to
286bb30
Compare
Proposed changes
This PR addresses Issue: [Link to Github issue within https://github.com/zowe/zlux/issues if any]
n/a
This PR depends upon the following PRs:
zowe-actions/zlux-builds/pull/45
Type of change
Please delete options that are not relevant.
PR Checklist
Please delete options that are not relevant.
n/a)n/a)n/a)n/a)n/a)Testing
n/a
Further comments
The fix enables the zowe-actions/zlux-builds/plugins/prepare-workflow to generate build information in the manifest.yaml.
VERSION: 2.0.2
CHANGELOG: Bugfix: Generate build information in manifest.