Skip to content

Improved reporting of errors in 'make doclinkcheck' in GitHub Actions #2091

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andy-maier merged 1 commit into from
Feb 4, 2026
Merged

Improved reporting of errors in 'make doclinkcheck' in GitHub Actions #2091

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -302,7 +302,6 @@ jobs:
RUN_TYPE: ${{ steps.set-run-type.outputs.result }}
run: |
make doclinkcheck
continue-on-error: true

test_finish:
needs: test
Expand Down
4 changes: 2 additions & 2 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -441,7 +441,7 @@ docchanges: $(doc_dependent_files)
.PHONY: doclinkcheck
doclinkcheck: $(doc_dependent_files)
@echo "Running Sphinx to check the doc links"
$(doc_cmd) -b linkcheck $(doc_opts) $(doc_build_dir)/linkcheck
@bash -c '$(doc_cmd) -b linkcheck $(doc_opts) $(doc_build_dir)/linkcheck; rc=$$?; if [ $$rc -ne 0 ]; then echo "::notice::doclinkcheck failed (ignored)"; fi'
@echo
@echo "Done: Look for any errors in the above output or in: $(doc_build_dir)/linkcheck/output.txt"
@echo "Makefile: $@ done."
Expand Down Expand Up @@ -661,7 +661,7 @@ $(done_dir)/check_reqs_$(pymn)_$(PACKAGE_LEVEL).done: Makefile $(done_dir)/devel
@echo "Makefile: Checking missing dependencies of this package"
cat requirements.txt extra-testutils-requirements.txt >tmp_requirements.txt
pip-missing-reqs $(package_name) --ignore-module $(package_name) --ignore-module $(mock_package_name) --requirements-file=tmp_requirements.txt
$(call RM_FUNC,tmp_requirements.txt)
-$(call RM_FUNC,tmp_requirements.txt)
pip-missing-reqs $(package_name) --ignore-module $(package_name) --ignore-module $(mock_package_name) --requirements-file=minimum-constraints-install.txt
@echo "Makefile: Done checking missing dependencies of this package"
ifeq ($(PLATFORM),Windows_native)
Expand Down
Loading