Skip to content

Improved reporting of errors in 'make doclinkcheck' in GitHub Actions#2091

Merged
andy-maier merged 1 commit intomasterfrom
andy/silence-make-errors
Feb 4, 2026
Merged

Improved reporting of errors in 'make doclinkcheck' in GitHub Actions#2091
andy-maier merged 1 commit intomasterfrom
andy/silence-make-errors

Conversation

@andy-maier
Copy link
Member

@andy-maier andy-maier commented Feb 4, 2026

No review needed; was reviewed in PR zhmcclient/zhmc-prometheus-exporter#865

@andy-maier andy-maier self-assigned this Feb 4, 2026
@andy-maier andy-maier added this to the 1.26.0 milestone Feb 4, 2026
@andy-maier andy-maier force-pushed the andy/silence-make-errors branch from 221600b to 8b2f6cb Compare February 4, 2026 08:33
@coveralls
Copy link
Collaborator

coveralls commented Feb 4, 2026

Coverage Status

coverage: 77.2%. remained the same
when pulling 4b75f18 on andy/silence-make-errors
into 697fb01 on master.

Details:

* Currently, errors detected by the Sphinx command in the 'doclinkcheck' make
  rule are handled in the Actions workflow step by ignoring the error.
  That causes an error to be shown in the Actions summary, without any
  information which step failed or what the error was.

  This change improves that by moving the ignoring of the error into the
  make commands, and by echoing a message that includes the string '::notice::'
  which causes the echoed string to be shown as an info message in the
  Actions summary.

Signed-off-by: Andreas Maier <maiera@de.ibm.com>
@andy-maier andy-maier force-pushed the andy/silence-make-errors branch from 8b2f6cb to 4b75f18 Compare February 4, 2026 09:05
@andy-maier andy-maier changed the title Changed handling of ignored make errors Improved reporting of errors in 'make doclinkcheck' in GitHub Actions Feb 4, 2026
@andy-maier andy-maier merged commit 0e5c969 into master Feb 4, 2026
15 checks passed
@andy-maier andy-maier deleted the andy/silence-make-errors branch February 4, 2026 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants