Skip to content

Spellcasting Refactor#182

Draft
zeel01 wants to merge 15 commits intomasterfrom
spellcasting-refactor
Draft

Spellcasting Refactor#182
zeel01 wants to merge 15 commits intomasterfrom
spellcasting-refactor

Conversation

@zeel01
Copy link
Owner

@zeel01 zeel01 commented Mar 16, 2022

Refactors the entire spellcasting system per #182

@zeel01 zeel01 added enhancement New feature or request Javascript Code issue Template Issues with Handlebars and HTML Refactor/TD Something that needs refactored, or addresses technical debt. labels Mar 16, 2022
@zeel01 zeel01 self-assigned this Mar 16, 2022
@zeel01 zeel01 linked an issue Mar 16, 2022 that may be closed by this pull request
7 tasks
@zeel01 zeel01 marked this pull request as draft March 16, 2022 19:54
@zeel01
Copy link
Owner Author

zeel01 commented Mar 16, 2022

Currently working on re-writing the entire spellbook organization system, this will replace both calls in the organizeSpellbook method:

organizeSpellbooks(spells) {
    this.data.spellbook = this.sheet._prepareSpellbook(this.data, spells);
    this.data.innateSpellbook = new InnateSpellbookPrep(this.data.spellbook, this.sheet).prepare();
}

The InnateSpellbookPrep class will be dropped, and reliance on the system-level _prepareSepllbook method will be dropped.

Currently, if you open a sheet the new spellbook data structures will be logged to the console, but the displayed info on the sheet is still unchanged.

@zeel01
Copy link
Owner Author

zeel01 commented May 18, 2022

I've started working on the new templates to handle the new spellcasting format, so far I just have really basic stuff in place so that something prints out using the new spellbook organization.

@zeel01
Copy link
Owner Author

zeel01 commented Jul 28, 2022

Alright, I've got it to the point where spellcasting features show up again, and they have descriptions and spell lists that work. Pretty close to parity with old features.

I don't think resources are working correctly yet, and I still need to implement some of the new complicated sorting logic. But the basics are now working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request Javascript Code issue Refactor/TD Something that needs refactored, or addresses technical debt. Template Issues with Handlebars and HTML

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Spellcasting Refactor

1 participant