Changed Recharge#181
Closed
jeremyregnerus wants to merge 3 commits intozeel01:masterfrom
jeremyregnerus:Recharged
Closed
Changed Recharge#181jeremyregnerus wants to merge 3 commits intozeel01:masterfrom jeremyregnerus:Recharged
jeremyregnerus wants to merge 3 commits intozeel01:masterfrom
jeremyregnerus:Recharged
Conversation
zeel01
requested changes
Mar 16, 2022
Owner
zeel01
left a comment
There was a problem hiding this comment.
Ah, yeah... I guess it's fair to convert this to the system rolls too. I really like my recharge roll though...
The exact way this displays needs some tweaks, but I agree with the over-all idea.
Collaborator
Author
|
Converted draft, waiting for #182 Spellcasting Refactor to rebase. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces changes to Recharge that I have incorporated in my local branch. I thought I would share them here to see if there is any interest. If not interested in these changed, feel free to close the PR.
asyncand waits until the roll is completed for mods like DiceSoNice to produce results after the roll is completedrollRechargecan still do sohtml.find("[data-roll-formula]").click, which appears to be solely used for item rechargefeatureBlock.hbsChargedandRechargeNChargedlocalization stringrecharged.mp4