Skip to content

Changed Recharge#181

Closed
jeremyregnerus wants to merge 3 commits intozeel01:masterfrom
jeremyregnerus:Recharged
Closed

Changed Recharge#181
jeremyregnerus wants to merge 3 commits intozeel01:masterfrom
jeremyregnerus:Recharged

Conversation

@jeremyregnerus
Copy link
Collaborator

@jeremyregnerus jeremyregnerus commented Mar 16, 2022

This PR introduces changes to Recharge that I have incorporated in my local branch. I thought I would share them here to see if there is any interest. If not interested in these changed, feel free to close the PR.

  • Changes the appearance of how Recharge works on the sheet
    • When the item is not charged, the text Recharge (n-6) appears in red letting the user know the item is not charged
    • When the user clicks Recharge, the NPC rolls the recharge
    • When the item is charged, the text Charged (n-6) appears in standard text format
    • When the item is charged, the text for recharge does not roll, or change format when hovering (the built in roll does not change the value when rolling recharge when the item is already charged)
  • Uses the DND5E built in recharge roll
    • I will say, I did like the colors in the chat card with the previous roll, however...
    • Built in recharge roll is async and waits until the roll is completed for mods like DiceSoNice to produce results after the roll is completed
    • Ensures any other mods that may leverage rollRecharge can still do so
    • Eliminates the needs for html.find("[data-roll-formula]").click, which appears to be solely used for item recharge
    • Eliminates the need for complex parameters for recharge roll in featureBlock.hbs
  • Reduces the localization requirements
    • Uses DND5E localization strings for Charged and Recharge
    • Removes the need for NCharged localization string
recharged.mp4

@jeremyregnerus jeremyregnerus added enhancement New feature or request CSS Stylesheets Javascript Code issue and removed CSS Stylesheets Javascript Code issue labels Mar 16, 2022
Copy link
Owner

@zeel01 zeel01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, yeah... I guess it's fair to convert this to the system rolls too. I really like my recharge roll though...

The exact way this displays needs some tweaks, but I agree with the over-all idea.

@jeremyregnerus jeremyregnerus requested a review from zeel01 March 16, 2022 16:06
@jeremyregnerus jeremyregnerus marked this pull request as draft March 25, 2022 19:00
@jeremyregnerus
Copy link
Collaborator Author

Converted draft, waiting for #182 Spellcasting Refactor to rebase.

@jeremyregnerus jeremyregnerus closed this by deleting the head repository Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants