Conversation
|
You can trigger an installable build for these changes by visiting CircleCI here. |
|
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
|
Related PRs and Writing flow sanity check tests ✅ |
Cover-1 ✔️
Button-1 ✔️
Button-2 ✔️
Button-3 ✔️Note: These tests could be improved by displaying the image for which "settings button" to press directly in the test steps (rather than linking to the image). At first, I conducted the tests using the block settings, instead of the RichText settings, until I realized intention was to first use the RichText settings button.
Button-4 ❓
All tests pass, but strange behavior / bug observed for button inside group block. For some reason, when I add a button inside a group block, it doesn't show changes in the preview that appear after the button. |
|
@mkevins I was not able to reproduce that problem, however, I was checking it on the simulator using release branch, because looks like Steps I went through:
Output: |
geriux
left a comment
There was a problem hiding this comment.
All good! We just need to change the commit for the tag.
|
Thanks for testing! |
Thanks for attempting to reproduce this @lukewalczak ! I have confirmed this bug does not require the group block. Also, I have confirmed that it does not appear to be related with button(s) block, which is where I originally encountered the issue while testing. This may be an issue with preview. I have now encountered this with the following steps:
On the third edit, I observed that the preview content was "stale". I'll open an issue for this. |


Related PRs
gutenberg-mobile: wordpress-mobile/gutenberg-mobile#2186
WordPress-Android: wordpress-mobile/WordPress-Android#11756
To test:
Bug fix
FloatingToolbaron the bottom of the screen Refactor: Fixed position ofFloatingToolbaron the bottom of the screen gutenberg-mobile#2118New feature & Improvement
Video block - don't force full screen on iOS Video block - don't force full screen on iOS gutenberg-mobile#1952This was revertedNote: including this to ensure we don't see the block in production yet:
PR submission checklist:
RELEASE-NOTES.txtif necessary.