Merged
Conversation
|
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
5 tasks
Result of running `python tools/merge_strings_xml.py`
Contributor
Author
|
|
…ild-no-jitpack Build gutenberg-mobile locally without JitPack
|
You can test the changes on this Pull Request by downloading the APK here. |
Contributor
Author
|
This branch now includes the avoid-jitpack changes, so merging this PR will bring those to |
3 tasks
…to-develop Gutenberg/no jitpack updates to gutenberg 1.28 branch
The automatic merge made some rather questionable conflict resolution decisions.
cameronvoell
approved these changes
May 15, 2020
Contributor
cameronvoell
left a comment
cameronvoell
left a comment
There was a problem hiding this comment.
Spot tested a couple changes from gb-mobile PR and it looked good. I also performed some builds with and without wp.BUILD_GUTENBERG_FROM_SOURCE equal to true (testing new jitpack changes) and everything looks good!
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merging Gutenberg 1.28.0 Release. 🎉
For changes that need to be tested, take a look at the related gutenberg-mobile PR: wordpress-mobile/gutenberg-mobile#2252
PR submission checklist:
RELEASE-NOTES.txtif necessary.