Skip to content

Conversation

@stof
Copy link
Contributor

@stof stof commented Oct 21, 2024

No description provided.

@stof
Copy link
Contributor Author

stof commented Oct 21, 2024

hmm, this change relies on full variance support to be compatible with Symfony 6. I see 2 ways to solve that

  • bump the min PHP version to PHP 7.4
  • rework the custom WebTestCase class to override less methods from the parent.

@stof stof mentioned this pull request Oct 21, 2024
@stof
Copy link
Contributor Author

stof commented Feb 19, 2025

@monteiro any preference for the solution ?

@monteiro
Copy link
Collaborator

I think we can bump the version.

@stof
Copy link
Contributor Author

stof commented Feb 19, 2025

@monteiro I updated the PR to bump the min PHP version.

@monteiro monteiro merged commit d2d5d62 into willdurand:master Feb 20, 2025
7 checks passed
@monteiro
Copy link
Collaborator

thanks!

@stof stof deleted the patch-3 branch February 20, 2025 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants