Skip to content

Conversation

@stof
Copy link
Contributor

@stof stof commented Oct 21, 2024

  • Remove jobs allowed to fail for stable PHP versions (keeping only jobs that requires passing, making that the default)
  • Add CI jobs for PHP 8.2, 8.3 and 8.4
  • Add an experimental (i.e. allowed to fail) job for PHP nightly
  • Remove the variant from the matrix as it is always normal
  • Remove the step fetching the composer cache location as this location is never used
  • Upgrade the ramsey/composer-install action to avoid deprecation warnings
  • ensure we don't cancel jobs for other PHP versions when one fails, to make it easier to determine whether a failure is version-specific.

@stof
Copy link
Contributor Author

stof commented Oct 21, 2024

failures with Symfony 7 are being handled in #369

@stof
Copy link
Contributor Author

stof commented Oct 21, 2024

@monteiro which solution do you prefer ?

- Remove jobs allowed to fail for stable PHP versions (keeping only jobs that requires passing, making that the default)
- Add CI jobs for PHP 8.2, 8.3 and 8.4
- Add an experimental (i.e. allowed to fail) job for PHP nightly
- Remove the `variant` from the matrix as it is always `normal`
- Remove the step fetching the composer cache location as this location is never used
- Upgrade the `ramsey/composer-install` action to avoid deprecation warnings
- Make sure jobs for all PHP versions are run until the end even when
  one of them fails, to make it easier to determine whether a failure is
  specific to a version
@stof
Copy link
Contributor Author

stof commented Feb 20, 2025

@monteiro I rebased this PR after the merge of my other PRs (as they were conflicting) so it is now ready to be reviewed as well.

@monteiro monteiro merged commit 08c3eea into willdurand:master Feb 20, 2025
8 checks passed
@stof stof deleted the patch-2 branch February 20, 2025 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants