Skip to content

feature: append to body #143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
nugthan wants to merge 4 commits into
base: main
Choose a base branch
from
+16 −3
Draft

feature: append to body #143

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1b81452
add global append
nugthan Dec 24, 2025
2e1a8bd
rename to appendToBody
nugthan Dec 24, 2025
dffa330
make props either-or
nugthan Dec 24, 2025
377accc
switch to allow body in renderTo
nugthan Dec 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/lib/components/modal/modal.module.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@
position: fixed;
}

.ModalAppend {
z-index: 9999;
}

.ModalAbsolute {
position: absolute;
}
15 changes: 12 additions & 3 deletions src/lib/components/modal/modal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,16 +11,25 @@ export interface ModalProps extends ModalInnerProps {
* The modal will be appended to the passed element instead of being rendered in place
* @defaultValue defaults inPlace
**/
renderTo: HTMLElement
renderTo?: HTMLElement | "body"
}

export function Modal({ renderTo, className, ...props }: ModalProps) {
const classes = classnames([styles.ModalFixed, className])
const appendToBody = renderTo === "body"

const classes = classnames([
styles.ModalFixed,
className,
appendToBody && styles.ModalAppend,
])

const modalContent = <ModalInner className={classes} {...props} />

if (renderTo) {
if (renderTo && renderTo instanceof HTMLElement) {
return ReactDOM.createPortal(modalContent, renderTo)
} else if (appendToBody) {
const document = globalThis.document
return ReactDOM.createPortal(modalContent, document)
}

return modalContent
Expand Down