bump agent-sandbox to v0.1.1#201
Conversation
Signed-off-by: Zhou Zihang <z@mcac.cc>
Summary of ChangesHello @acsoto, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on updating the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request correctly updates sigs.k8s.io/agent-sandbox to v0.1.1 and adapts the codebase to the new API. The changes include fixing a typo in SandboxPodNameAnnotation and restructuring the sandbox spec to use the new Lifecycle.ShutdownTime field. All modifications in the Go modules, application code, and tests are consistent and accurate. The PR is well-executed and achieves its goal of aligning with the updated dependency.
There was a problem hiding this comment.
Pull request overview
This PR updates the sigs.k8s.io/agent-sandbox dependency from v0.1.0 to v0.1.1 to incorporate an upstream typo fix and API restructuring. The upstream changes moved the ShutdownTime field from SandboxSpec directly to SandboxSpec.Lifecycle, and corrected the spelling of SandboxPodNameAnnotation (previously misspelled as SanboxPodNameAnnotation).
Changes:
- Bumps agent-sandbox from v0.1.0 to v0.1.1 in go.mod, pulling in transitive dependency updates
- Fixes typo in annotation constant usage: SanboxPodNameAnnotation → SandboxPodNameAnnotation
- Restructures ShutdownTime field access to use new Lifecycle wrapper in buildSandboxObject
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| go.mod | Updates agent-sandbox to v0.1.1 and golang.org/x/net to v0.47.0 |
| go.sum | Adds transitive dependencies from agent-sandbox v0.1.1 upgrade (OpenTelemetry, gRPC, golang.org/x packages) |
| pkg/workloadmanager/workload_builder.go | Wraps ShutdownTime field in new Lifecycle struct when building Sandbox specs |
| pkg/workloadmanager/handlers.go | Fixes typo in annotation constant reference |
| pkg/workloadmanager/handlers_test.go | Fixes typo in annotation constant reference in test helper |
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #201 +/- ##
==========================================
+ Coverage 35.60% 35.75% +0.14%
==========================================
Files 29 29
Lines 2533 2551 +18
==========================================
+ Hits 902 912 +10
- Misses 1505 1513 +8
Partials 126 126
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Zhou Zihang <z@mcac.cc>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hzxuzhonghu The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind bug
What this PR does / why we need it:
This updates
sigs.k8s.io/agent-sandboxto v0.1.1 to pick up the upstream typo fix forSandboxPodNameAnnotationand aligns our code with the updated API. It also adapts the workload manager’s sandbox spec to the newLifecycle.ShutdownTimefield. This avoids build breaks when the dependency is bumped and keeps our usage consistent with the upstream API change.Root cause: v0.1.0 exposed
SanboxPodNameAnnotationandShutdownTimedirectly onSandboxSpec. In v0.1.1 the annotation constant was corrected andShutdownTimewas moved underLifecycle, so our references became stale. This change updates those references to the v0.1.1 API shape.Which issue(s) this PR fixes:
Fixes # (N/A)
Special notes for your reviewer:
go.mod/go.suminclude transitive bumps pulled in by the v0.1.1 upgrade (notablygolang.org/x/*andoteldependencies).Does this PR introduce a user-facing change?: