Skip to content

bump agent-sandbox to v0.1.1#201

Merged
volcano-sh-bot merged 2 commits intovolcano-sh:mainfrom
acsoto:bump-agent-sandbox-0.1.1
Feb 6, 2026
Merged

bump agent-sandbox to v0.1.1#201
volcano-sh-bot merged 2 commits intovolcano-sh:mainfrom
acsoto:bump-agent-sandbox-0.1.1

Conversation

@acsoto
Copy link
Contributor

@acsoto acsoto commented Feb 5, 2026

What type of PR is this?

/kind bug

What this PR does / why we need it:
This updates sigs.k8s.io/agent-sandbox to v0.1.1 to pick up the upstream typo fix for SandboxPodNameAnnotation and aligns our code with the updated API. It also adapts the workload manager’s sandbox spec to the new Lifecycle.ShutdownTime field. This avoids build breaks when the dependency is bumped and keeps our usage consistent with the upstream API change.

Root cause: v0.1.0 exposed SanboxPodNameAnnotation and ShutdownTime directly on SandboxSpec. In v0.1.1 the annotation constant was corrected and ShutdownTime was moved under Lifecycle, so our references became stale. This change updates those references to the v0.1.1 API shape.

Which issue(s) this PR fixes:
Fixes # (N/A)

Special notes for your reviewer:
go.mod/go.sum include transitive bumps pulled in by the v0.1.1 upgrade (notably golang.org/x/* and otel dependencies).

Does this PR introduce a user-facing change?:

NONE

Signed-off-by: Zhou Zihang <z@mcac.cc>
Copilot AI review requested due to automatic review settings February 5, 2026 08:50
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @acsoto, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on updating the agent-sandbox dependency to its latest version, v0.1.1, to ensure compatibility with recent upstream API modifications. The changes address a typographical error in an annotation constant and restructure a key field within the sandbox specification, which are critical for preventing build failures and maintaining consistency with the updated library. This ensures the project remains aligned with the evolving agent-sandbox API.

Highlights

  • Dependency Update: Bumped the sigs.k8s.io/agent-sandbox dependency from v0.1.0 to v0.1.1.
  • API Alignment: Corrected a typo in the SandboxPodNameAnnotation constant and adapted the workload manager's sandbox specification to move ShutdownTime under a new Lifecycle field, aligning with upstream API changes.
  • Transitive Dependency Updates: Updated several transitive Go dependencies, including golang.org/x/* packages and various go.opentelemetry.io components.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • go.mod
    • Updated sigs.k8s.io/agent-sandbox from v0.1.0 to v0.1.1.
    • Updated golang.org/x/net from v0.45.0 to v0.47.0.
    • Added new indirect dependencies including github.com/cenkalti/backoff/v5, github.com/go-logr/stdr, github.com/grpc-ecosystem/grpc-gateway/v2, and several go.opentelemetry.io packages.
    • Updated various golang.org/x/* indirect dependencies (e.g., crypto, oauth2, sync, sys, term, text).
    • Added new indirect google.golang.org/genproto and google.golang.org/grpc dependencies.
  • go.sum
    • Updated checksums for all modified and newly added dependencies to reflect changes in go.mod.
  • pkg/workloadmanager/handlers.go
    • Corrected the annotation constant from controllers.SanboxPodNameAnnotation to controllers.SandboxPodNameAnnotation.
  • pkg/workloadmanager/handlers_test.go
    • Updated the test case to use the corrected controllers.SandboxPodNameAnnotation.
  • pkg/workloadmanager/workload_builder.go
    • Modified the buildSandboxObject function to move the ShutdownTime field into the Lifecycle sub-struct within the SandboxSpec, aligning with the updated API.
Activity
  • The pull request was created by acsoto.
  • The author provided a detailed description outlining the purpose and impact of the changes, including specific API adjustments and transitive dependency bumps.
  • No human review comments or other activity are available in the provided context.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly updates sigs.k8s.io/agent-sandbox to v0.1.1 and adapts the codebase to the new API. The changes include fixing a typo in SandboxPodNameAnnotation and restructuring the sandbox spec to use the new Lifecycle.ShutdownTime field. All modifications in the Go modules, application code, and tests are consistent and accurate. The PR is well-executed and achieves its goal of aligning with the updated dependency.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the sigs.k8s.io/agent-sandbox dependency from v0.1.0 to v0.1.1 to incorporate an upstream typo fix and API restructuring. The upstream changes moved the ShutdownTime field from SandboxSpec directly to SandboxSpec.Lifecycle, and corrected the spelling of SandboxPodNameAnnotation (previously misspelled as SanboxPodNameAnnotation).

Changes:

  • Bumps agent-sandbox from v0.1.0 to v0.1.1 in go.mod, pulling in transitive dependency updates
  • Fixes typo in annotation constant usage: SanboxPodNameAnnotation → SandboxPodNameAnnotation
  • Restructures ShutdownTime field access to use new Lifecycle wrapper in buildSandboxObject

Reviewed changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
go.mod Updates agent-sandbox to v0.1.1 and golang.org/x/net to v0.47.0
go.sum Adds transitive dependencies from agent-sandbox v0.1.1 upgrade (OpenTelemetry, gRPC, golang.org/x packages)
pkg/workloadmanager/workload_builder.go Wraps ShutdownTime field in new Lifecycle struct when building Sandbox specs
pkg/workloadmanager/handlers.go Fixes typo in annotation constant reference
pkg/workloadmanager/handlers_test.go Fixes typo in annotation constant reference in test helper

@codecov-commenter
Copy link

codecov-commenter commented Feb 5, 2026

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 14.28571% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 35.75%. Comparing base (845b798) to head (c9f9f1e).
⚠️ Report is 46 commits behind head on main.

Files with missing lines Patch % Lines
pkg/workloadmanager/workload_builder.go 0.00% 4 Missing ⚠️
pkg/workloadmanager/sandbox_helper.go 0.00% 1 Missing and 1 partial ⚠️
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #201      +/-   ##
==========================================
+ Coverage   35.60%   35.75%   +0.14%     
==========================================
  Files          29       29              
  Lines        2533     2551      +18     
==========================================
+ Hits          902      912      +10     
- Misses       1505     1513       +8     
  Partials      126      126              
Flag Coverage Δ
unittests 35.75% <14.28%> (+0.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@acsoto acsoto changed the title [codex] bump agent-sandbox to v0.1.1 bump agent-sandbox to v0.1.1 Feb 6, 2026
@acsoto acsoto marked this pull request as ready for review February 6, 2026 01:54
Signed-off-by: Zhou Zihang <z@mcac.cc>
Copy link
Member

@hzxuzhonghu hzxuzhonghu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hzxuzhonghu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot merged commit 695adb1 into volcano-sh:main Feb 6, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants