This repository was archived by the owner on Apr 8, 2022. It is now read-only.
Fix to allow watching multiple namespaces#152
Open
vaamarnath wants to merge 1 commit intovmware-archive:masterfrom
vaamarnath:issue-132-support-multiple-namespaces
Open
Fix to allow watching multiple namespaces#152vaamarnath wants to merge 1 commit intovmware-archive:masterfrom vaamarnath:issue-132-support-multiple-namespaces
vaamarnath wants to merge 1 commit intovmware-archive:masterfrom
vaamarnath:issue-132-support-multiple-namespaces
Conversation
The list of namespaces to watch can be provided in the configuration as a list. If no items are present in the list, all namespaces are watched. Fixes #132 Signed-off-by: Amarnath <vaamarnath@gmail.com>
|
Please merge this I need it thx :) |
|
Is this ever going to be merged? Been over a year and this is sort of helpfull for Openshift when you are not cluster admin. |
|
I think it's reasonable. However the pr drifted from master and we need help with rebasing it |
|
Yes please
…On Mon, Sep 21, 2020, 16:40 Luis Miguel Miranda ***@***.***> wrote:
@mkmik <https://github.com/mkmik> Since i wanted to check in in my Orgs
Openshift cluster I cloned the master and applied the changes from this PR.
https://github.com/luis-miguel-miranda/kubewatch
Works fine with several projects and with none.
Is it useful if i create a new PR?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#152 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAM3QICAY2OSEO764GOSY3SG5QVXANCNFSM4GC7ISPQ>
.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The list of namespaces to watch can be provided in the configuration
as a list. If no items are present in the list, all namespaces are
watched.
Fixes #132