This repository was archived by the owner on Apr 8, 2022. It is now read-only.
Multiple namespaces feature#242
Open
luis-miguel-miranda wants to merge 1 commit intovmware-archive:masterfrom
Open
Multiple namespaces feature#242luis-miguel-miranda wants to merge 1 commit intovmware-archive:masterfrom
luis-miguel-miranda wants to merge 1 commit intovmware-archive:masterfrom
Conversation
|
Can you merge this pr . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request contains a working version of multiple namespaces selection.
I've tried the code changes from PR 152. However this code resulted in multiple notifications for the same event and issues with inconsistency while adding several namespaces watchers.
Here we create a thread per namespace when appropriate.
This feature is particularly helpful when you want to monitor a namespace of a cluster you are not admin as kubewatch allows that.
Note I am neither well versed on go nor spent a major amount of time on this. If the implementation sucks feel free to throw away. However the features have been working well in Openshift and AKS environments I use on and enterprise setting and may be useful for others.