Skip to content

[Address form] Update label color & fix required asterisk issue on province selector #453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
aprentout wants to merge 1 commit into from
Closed

[Address form] Update label color & fix required asterisk issue on province selector #453

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 14 additions & 11 deletions addon/components/utils/address-form.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
{{#unless @hideNameAttrs}}
<div class="fx-row fx-gap-px-12">
<div class="fx-col fx-gap-px-6 fx-1">
<label {{required-input}}>
<label class="font-size-md font-color-gray-500" {{required-input}}>
Copy link
Member

@Miexil Miexil Feb 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔 🤔 🤔
shouldn't the usage of <label> be enough ?

{{t "upf_utils.address_form.first_name"}}
</label>
<OSS::InputContainer
Expand All @@ -15,7 +15,7 @@
</div>

<div class="fx-col fx-gap-px-6 fx-1">
<label {{required-input}}>
<label class="font-size-md font-color-gray-500" {{required-input}}>
{{t "upf_utils.address_form.last_name"}}
</label>
<OSS::InputContainer
Expand All @@ -31,7 +31,7 @@

{{#unless @hidePhoneNumber}}
<div class="fx-col fx-gap-px-6">
<label {{required-input}}>
<label class="font-size-md font-color-gray-500" {{required-input}}>
{{t "upf_utils.address_form.phone_number"}}
</label>
{{#if @usePhoneNumberInput}}
Expand All @@ -55,7 +55,7 @@
{{/unless}}
<div class="fx-row fx-gap-px-12">
<div class="fx-col fx-gap-px-6 fx-1">
<label {{required-input}}>
<label class="font-size-md font-color-gray-500" {{required-input}}>
{{t "upf_utils.address_form.line_1"}}
</label>
{{#if this.useGoogleAutocomplete}}
Expand All @@ -81,7 +81,7 @@
</div>

<div class="fx-col fx-gap-px-6 fx-1">
<label>
<label class="font-size-md font-color-gray-500">
{{t "upf_utils.address_form.line_2"}}
</label>
<OSS::InputContainer
Expand All @@ -96,7 +96,7 @@

<div class="fx-row fx-gap-px-12">
<div class="fx-col fx-gap-px-6 fx-1" data-control-name="address-form">
<label {{required-input}}>
<label class="font-size-md font-color-gray-500" {{required-input}}>
{{t "upf_utils.address_form.country"}}
</label>
<OSS::CountrySelector
Expand All @@ -108,10 +108,10 @@
</div>

<div class="fx-col fx-gap-px-6 fx-1">
<label {{(if this.provincesForCountry (modifier "required-input"))}}>
{{t "upf_utils.address_form.state"}}
</label>
{{#if this.provincesForCountry}}
<label class="font-size-md font-color-gray-500" {{required-input}}>
{{t "upf_utils.address_form.state"}}
</label>
<OSS::ProvinceSelector
@value={{@address.state}}
@sourceList={{this.provincesForCountry}}
Expand All @@ -120,6 +120,9 @@
{{(if (eq @focus "state") (modifier "enable-input-autofocus"))}}
/>
{{else}}
<label class="font-size-md font-color-gray-500">
{{t "upf_utils.address_form.state"}}
</label>
<OSS::InputContainer
@value={{@address.state}}
@onChange={{fn this.onFieldUpdate "state"}}
Expand All @@ -133,7 +136,7 @@

<div class="fx-row fx-gap-px-12">
<div class="fx-col fx-gap-px-6 fx-1">
<label {{required-input}}>
<label class="font-size-md font-color-gray-500" {{required-input}}>
{{t "upf_utils.address_form.city"}}
</label>
<OSS::InputContainer
Expand All @@ -146,7 +149,7 @@
</div>

<div class="fx-col fx-gap-px-6 fx-1">
<label {{required-input}}>
<label class="font-size-md font-color-gray-500" {{required-input}}>
{{t "upf_utils.address_form.postal_code"}}
</label>
<OSS::InputContainer
Expand Down