[Address form] Update label color & fix required asterisk issue on province selector#453
Closed
[Address form] Update label color & fix required asterisk issue on province selector#453
Conversation
aprentout
requested review from
nathalieArnoux and
olxmpe
and removed request for
a team
Miexil
reviewed
Feb 11, 2026
| <div class="fx-row fx-gap-px-12"> | ||
| <div class="fx-col fx-gap-px-6 fx-1"> | ||
| <label {{required-input}}> | ||
| <label class="font-size-md font-color-gray-500" {{required-input}}> |
Member
There was a problem hiding this comment.
🤔 🤔 🤔
shouldn't the usage of <label> be enough ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Related to: #DRA-4666
What are the observable changes?
🧑💻 Developer Heads Up
⚡ Since we are using Ember Octane now:
Useful Resource : Ember Octane vs Classic Cheat Sheet
Good PR checklist